[ResponseOps] [Cases] Attach file to case API #198377
Merged
+1,254
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
adcoelho
added
the
release_note:feature
cnasikas
reviewed
Nov 5, 2024
cnasikas
reviewed
Nov 12, 2024
x-pack/test/cases_api_integration/security_and_spaces/tests/common/files/post_file.ts
Outdated
Show resolved
Hide resolved
adcoelho
force-pushed
the
add-files-API-cases
branch
from
660c1ce
to
650289f
Compare
cnasikas
approved these changes
Nov 14, 2024
| expect(clientArgs.fileService.delete).toHaveBeenCalledWith({ id }); | ||
| }); | ||
|
|
||
| it('calls buildAttachmentRequestFromFileJSON with the correct params', async () => { |
There was a problem hiding this comment.
nit: What do you think instead of mocking buildAttachmentRequestFromFileJSONMock to check if the attachmentService was called with the correct args?
There was a problem hiding this comment.
That was my initial idea but we don't call attachmentService directly. We do:
const model = await CaseCommentModel.create(caseId, clientArgs);
const updatedModel = await model.createComment({
createdDate,
commentReq,
id: savedObjectID,
});
```
And I was losing too much time trying to mock this properly so I just wanted to ensure we build the request correctly.
There was a problem hiding this comment.
If you follow model.createComment you will see that it uses the attachment service to create the attachment. No need to mock the model.
There was a problem hiding this comment.
ah cool, I was wondering why you wrote attachmentService since I don't use that in add_file
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @adcoelho |
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Nov 14, 2024
Fixes elastic#22832 ## Summary This PR adds the possibility of adding Files/Attachments to Case in Kibana via an API call. ### How to test The new API URL is `https://localhost:5601/api/cases/<CASE_ID>/files`. You can either use postman or curl to test. 1. Start by creating a case. 2. Call the new API ``` curl --location 'https://localhost:5601/api/cases/<CASE_ID>/files' \ --header 'kbn-xsrf: true' \ --header 'Authorization: Basic ZWxhc3RpYzpjaGFuZ2VtZQ==' \ --form 'filename="Notice"' \ --form 'mimeType="text/plain"' \ --form 'file=@"<FULL_PATH_TO_THE_FILE_YOU_WANT_TO_UPLOAD>"' ``` <img width="1090" alt="Screenshot 2024-10-30 at 15 41 26" src="https://github.com/user-attachments/assets/b018f92d-2603-4bf1-ac12-f01452f35303"> 3. Confirm the user action was created. <img width="383" alt="Screenshot 2024-10-30 at 15 48 45" src="https://github.com/user-attachments/assets/04952b8f-e8fb-4f19-a72f-54030f496fe9"> 4. Confirm the file exists in the case and: - it can be downloaded as expected. - it can be previewed as expected(not every MIME type allows this). ### Release Notes Files can now be attached to cases directly via API. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: lcawl <lcawley@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22832
Summary
This PR adds the possibility of adding Files/Attachments to Case in Kibana via an API call.
How to test
The new API URL is
https://localhost:5601/api/cases/<CASE_ID>/files. You can either use postman or curl to test.Release Notes
Files can now be attached to cases directly via API.