Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Migrate test apm-api-integration/tests/errors to be deployment agnostic api tests #199655

Conversation

jennypavlova
Copy link
Member

@jennypavlova jennypavlova commented Nov 11, 2024

Closes #198971
Part of #193245

Summary

This PR migrates test apm-api-integration/tests/errors to be deployment agnostic api tests

Testing

Serverless:

node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"

Stateful:

node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"

@jennypavlova jennypavlova added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Nov 11, 2024
@jennypavlova jennypavlova self-assigned this Nov 11, 2024
@jennypavlova
Copy link
Member Author

/ci

@jennypavlova jennypavlova changed the title [APM] Migrate testapm api integration/tests/errors to be deployment agnostic api tests [APM] Migrate test apm-api-integration/tests/errors to be deployment agnostic api tests Nov 11, 2024
@jennypavlova jennypavlova marked this pull request as ready for review November 13, 2024 15:24
@jennypavlova jennypavlova requested review from a team as code owners November 13, 2024 15:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@jennypavlova jennypavlova added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Nov 13, 2024
@jennypavlova
Copy link
Member Author

jennypavlova commented Nov 13, 2024

Flaky test runner build

Copy link
Contributor

@miloszmarcinkowski miloszmarcinkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 just check below please

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 13, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7394

[✅] x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts: 25/25 tests passed.
[✅] x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts: 25/25 tests passed.

see run history

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 13, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 796b57a
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-199655-796b57ad7af1

Metrics [docs]

✅ unchanged

History

cc @jennypavlova

@jennypavlova jennypavlova merged commit 7921f56 into elastic:main Nov 14, 2024
24 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11834557478

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 14, 2024
…t agnostic api tests (elastic#199655)

Closes elastic#198971
Part of elastic#193245

## Summary

This PR migrates test apm-api-integration/tests/errors to be deployment
agnostic api tests

## Testing

Serverless:

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```
Stateful:

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```

(cherry picked from commit 7921f56)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 14, 2024
… to be deployment agnostic api tests (#199655) (#200130)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[APM] Migrate test `apm-api-integration/tests/errors` to be
deployment agnostic api tests
(#199655)](#199655)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2024-11-14T09:39:46Z","message":"[APM]
Migrate test `apm-api-integration/tests/errors` to be deployment
agnostic api tests (#199655)\n\nCloses #198971 \r\nPart of
#193245\r\n\r\n## Summary\r\n\r\nThis PR migrates test
apm-api-integration/tests/errors to be deployment\r\nagnostic api
tests\r\n\r\n## Testing\r\n\r\nServerless:\r\n\r\n```\r\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
--grep=\"APM\"\r\n```\r\nStateful:\r\n\r\n```\r\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
--grep=\"APM\"\r\n```","sha":"7921f5618d6af8e959ed4c52a91a026c672955ea","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[APM]
Migrate test `apm-api-integration/tests/errors` to be deployment
agnostic api
tests","number":199655,"url":"https://github.com/elastic/kibana/pull/199655","mergeCommit":{"message":"[APM]
Migrate test `apm-api-integration/tests/errors` to be deployment
agnostic api tests (#199655)\n\nCloses #198971 \r\nPart of
#193245\r\n\r\n## Summary\r\n\r\nThis PR migrates test
apm-api-integration/tests/errors to be deployment\r\nagnostic api
tests\r\n\r\n## Testing\r\n\r\nServerless:\r\n\r\n```\r\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
--grep=\"APM\"\r\n```\r\nStateful:\r\n\r\n```\r\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
--grep=\"APM\"\r\n```","sha":"7921f5618d6af8e959ed4c52a91a026c672955ea"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199655","number":199655,"mergeCommit":{"message":"[APM]
Migrate test `apm-api-integration/tests/errors` to be deployment
agnostic api tests (#199655)\n\nCloses #198971 \r\nPart of
#193245\r\n\r\n## Summary\r\n\r\nThis PR migrates test
apm-api-integration/tests/errors to be deployment\r\nagnostic api
tests\r\n\r\n## Testing\r\n\r\nServerless:\r\n\r\n```\r\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
--grep=\"APM\"\r\n```\r\nStateful:\r\n\r\n```\r\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
--grep=\"APM\"\r\n```","sha":"7921f5618d6af8e959ed4c52a91a026c672955ea"}}]}]
BACKPORT-->

Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Migrate /test/apm_api_integration/tests/errors/ to be deployment-agnostic API tests
5 participants