[Ownership] Assign test files to Shared UX Team #199779
Conversation
…anch 'main' of github.com:elastic/kibana
wayneseymour
added
release_note:skip
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
.github/CODEOWNERS
Outdated
| /test/functional/apps/home @elastic/appex-sharedux # Assigned per https://github.com/elastic/kibana/pull/199771/files#r1840075278 | ||
| /x-pack/test/plugin_functional/plugins/global_search_test @elastic/appex-sharedux | ||
| /test/functional/services/saved_objects_finder.ts @elastic/appex-sharedux | ||
| /test/interpreter_functional/test_suites/run_pipeline @elastic/appex-sharedux |
There was a problem hiding this comment.
seem like this falls under /test/interpreter_functional above and can be removed
.github/CODEOWNERS
Outdated
| @@ -2027,19 +2027,46 @@ x-pack/test/profiling_api_integration @elastic/obs-ux-infra_services-team | |||
| x-pack/plugins/observability_solution/observability_shared/public/components/profiling @elastic/obs-ux-infra_services-team | |||
|
|
|||
| # Shared UX | |||
| /test/api_integration/apis/guided_onboarding @elastic/appex-sharedux | |||
| /test/interpreter_functional @elastic/appex-sharedux # Assigned per https://github.com/elastic/kibana/pull/199767/files/9eb7f6e32e7645ffde6e5e8eaae72bf7f15a6f70#r1838041461 | |||
There was a problem hiding this comment.
I think @elastic/kibana-visualizations is a better owner as this is part of expressions
.github/CODEOWNERS
Outdated
| /x-pack/test/functional_solution_sidenav/index.ts @elastic/appex-sharedux | ||
| /x-pack/test/functional_cloud @elastic/appex-sharedux | ||
| /x-pack/test/functional/services/user_menu.js @elastic/appex-sharedux # Assigned per https://github.com/elastic/kibana/pull/179270 | ||
| /x-pack/test/functional/services/ace_editor.js @elastic/appex-sharedux |
There was a problem hiding this comment.
This service can be removed. Fine to keep the assignment in the PR, will follow up later
There was a problem hiding this comment.
@wayneseymour Actually... it seems that the service is still used by tests, which surprises me because I thought we completely removed ace editor. I think this better be assigned to @elastic/kibana-management
There was a problem hiding this comment.
Send this our way, seems I might have forgotten to remove these specific test service. I'll create an issue to address it. Odd that tests that depend on it still pass since the ace dependency is gone 🥲
There was a problem hiding this comment.
@sabarasaba It's been sent your way! :)
## Summary Assign test files to Shared UX Team Contributes to: elastic#192979 --------- Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Summary
Assign test files to Shared UX Team
Contributes to: #192979