[Console] Fix incorrect output message when status code is 200 and body is empty #199975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
Feature:Console
sabarasaba
changed the title
💚 Build Succeeded
Metrics [docs]Async chunks
cc @sabarasaba |
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
mattkime
approved these changes
Nov 13, 2024
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 14, 2024
…dy is empty (elastic#199975) (cherry picked from commit 35c2a9e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 14, 2024
…and body is empty (#199975) (#200122) # Backport This will backport the following commits from `main` to `8.x`: - [[Console] Fix incorrect output message when status code is 200 and body is empty (#199975)](#199975) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"rivasign@gmail.com"},"sourceCommit":{"committedDate":"2024-11-14T08:27:31Z","message":"[Console] Fix incorrect output message when status code is 200 and body is empty (#199975)","sha":"35c2a9e31e39f068c62767dc455b26e7ce7efb0c","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Console] Fix incorrect output message when status code is 200 and body is empty","number":199975,"url":"https://github.com/elastic/kibana/pull/199975","mergeCommit":{"message":"[Console] Fix incorrect output message when status code is 200 and body is empty (#199975)","sha":"35c2a9e31e39f068c62767dc455b26e7ce7efb0c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199975","number":199975,"mergeCommit":{"message":"[Console] Fix incorrect output message when status code is 200 and body is empty (#199975)","sha":"35c2a9e31e39f068c62767dc455b26e7ce7efb0c"}}]}] BACKPORT--> Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198010
Summary
This small PR resolves an issue where the API returns a 200 status with an empty body. The update ensures that an “OK” message is displayed instead of an error.