Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16] [Security Solution] Migration of Alert Page controls for non-default Spaces. (#200058) #200104

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

logeekal
Copy link
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Jatin Kathuria "}},{"branch":"8.16","label":"v8.16.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->

…Spaces. (elastic#200058)

## Summary

Recently, we created a PR to migrate the alert page filters controls to
`8.16`. Unfortunately, it does not do migration for non-default spaces
so any users upgrading to `8.16` will face the issue where Alert page
errors out as shown in below screenshot.

![grafik](https://github.com/user-attachments/assets/ffee1c2d-4aa2-44a4-96c9-68053fb1cf63)

## Desk Testing

1. Checkout to `v8.15` branch by running `git checkout 8.15`.
2. Create a new space and go to that space.
3. Go to the alert page and do some modifications to the page controls.
This store `v8.15` page controls in local storage.
    - You can, for example, delete one page control.
    - Change selected value for one page control.
    - Additionally, you can also add a custom control.
4. Checkout `main` now and repeat the above steps.
5. Your changes should be retained on the alert page and there should
not be any error.

(cherry picked from commit b7ca722)
@logeekal logeekal merged commit 591c595 into elastic:8.16 Nov 14, 2024
37 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.6MB 20.6MB +211.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 88.3KB 88.3KB +8.0B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants