[Security Solution] Fix Auto-grow behaviour of Filter Page Controls #200152
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logeekal
added
backport
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
adcoelho
approved these changes
Nov 14, 2024
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 14, 2024
…lastic#200152) ## Summary PR : elastic#199408 disables `auto` grow behaviour page filters controls which has been default behavior for some time. It causes issue on the page filters of Security and probably Observability as well since Page Filter controls do not grow anymore. |Correct in 8.16| Broken in 8.17/9.0.0| |---|---| ||| (cherry picked from commit a7470dd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 14, 2024
…rols (#200152) (#200173) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Fix Auto-grow behaviour of Filter Page Controls (#200152)](#200152) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2024-11-14T13:09:28Z","message":"[Security Solution] Fix Auto-grow behaviour of Filter Page Controls (#200152)\n\n## Summary\r\n\r\nPR : #199408 disables `auto` grow\r\nbehaviour page filters controls which has been default behavior for some\r\ntime.\r\n\r\nIt causes issue on the page filters of Security and probably\r\nObservability as well since Page Filter controls do not grow anymore.\r\n\r\n|Correct in 8.16| Broken in 8.17/9.0.0|\r\n|---|---|\r\n\r\n|||","sha":"a7470dd0473259418b1af748c94cc6f51dbcd41f","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","Team:ResponseOps","v9.0.0","Team:Threat Hunting:Investigations","v8.17.0"],"title":"[Security Solution] Fix Auto-grow behaviour of Filter Page Controls","number":200152,"url":"https://github.com/elastic/kibana/pull/200152","mergeCommit":{"message":"[Security Solution] Fix Auto-grow behaviour of Filter Page Controls (#200152)\n\n## Summary\r\n\r\nPR : #199408 disables `auto` grow\r\nbehaviour page filters controls which has been default behavior for some\r\ntime.\r\n\r\nIt causes issue on the page filters of Security and probably\r\nObservability as well since Page Filter controls do not grow anymore.\r\n\r\n|Correct in 8.16| Broken in 8.17/9.0.0|\r\n|---|---|\r\n\r\n|||","sha":"a7470dd0473259418b1af748c94cc6f51dbcd41f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200152","number":200152,"mergeCommit":{"message":"[Security Solution] Fix Auto-grow behaviour of Filter Page Controls (#200152)\n\n## Summary\r\n\r\nPR : #199408 disables `auto` grow\r\nbehaviour page filters controls which has been default behavior for some\r\ntime.\r\n\r\nIt causes issue on the page filters of Security and probably\r\nObservability as well since Page Filter controls do not grow anymore.\r\n\r\n|Correct in 8.16| Broken in 8.17/9.0.0|\r\n|---|---|\r\n\r\n|||","sha":"a7470dd0473259418b1af748c94cc6f51dbcd41f"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR : #199408 disables
autogrow behaviour page filters controls which has been default behavior for some time.It causes issue on the page filters of Security and probably Observability as well since Page Filter controls do not grow anymore.