Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Security Solution] Fix Auto-grow behaviour of Filter Page Controls (#200152) #200173

Merged
merged 1 commit into from
Nov 14, 2024
Merged

[8.x] [Security Solution] Fix Auto-grow behaviour of Filter Page Controls (#200152) #200173

merged 1 commit into from
Nov 14, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@logeekal
[Security Solution] Fix Auto-grow behaviour of Filter Page Controls (e…
4e18c1e 
…lastic#200152)

## Summary

PR : elastic#199408 disables `auto` grow
behaviour page filters controls which has been default behavior for some
time.

It causes issue on the page filters of Security and probably
Observability as well since Page Filter controls do not grow anymore.

|Correct in 8.16| Broken in 8.17/9.0.0|
|---|---|

|![image](https://github.com/user-attachments/assets/cc120c75-971c-44e6-bd63-65e5193cc0e5)|![image](https://github.com/user-attachments/assets/9a83a75d-70e2-4543-b9db-d0cbee24a404)|

(cherry picked from commit a7470dd)
@kibanamachine kibanamachine enabled auto-merge (squash) November 14, 2024 13:14
@kibanamachine kibanamachine mentioned this pull request Nov 14, 2024
Merged
@kibanamachine kibanamachine merged commit b990477 into elastic:8.x Nov 14, 2024
25 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #72 / APM API tests transactions/transactions_groups_alerts.spec.ts basic no archive when data is loaded Alerts Transaction groups with avg transaction duration alerts returns the correct number of alert counts

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.4MB 13.4MB +8.0B
triggersActionsUi 1.7MB 1.7MB +8.0B
total +16.0B

cc @logeekal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@logeekal logeekal

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @logeekal