Remove modelId from config
#200181
Merged
Remove modelId from config
#200181
+0
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
sorenlouv
added
backport:prev-minor
neptunian
approved these changes
Nov 14, 2024
💚 Build Succeeded
Metrics [docs]
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 15, 2024
Follow up to elastic#186499 This removes `modelId` from the config file. We don't need it anymore since it can be supplied as a url param. Currently it's only needed in the setup route (`POST /internal/observability_ai_assistant/kb/setup`) (cherry picked from commit 875313e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 15, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Remove `modelId` from config (#200181)](#200181) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Søren Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2024-11-15T05:58:20Z","message":"Remove `modelId` from config (#200181)\n\nFollow up to https://github.com/elastic/kibana/pull/186499\r\n\r\nThis removes `modelId` from the config file. We don't need it anymore\r\nsince it can be supplied as a url param. Currently it's only needed in\r\nthe setup route (`POST /internal/observability_ai_assistant/kb/setup`)","sha":"875313e751e70131185459533bd1bfae74efc32b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:Obs AI Assistant","ci:project-deploy-observability"],"title":"Remove `modelId` from config","number":200181,"url":"https://github.com/elastic/kibana/pull/200181","mergeCommit":{"message":"Remove `modelId` from config (#200181)\n\nFollow up to https://github.com/elastic/kibana/pull/186499\r\n\r\nThis removes `modelId` from the config file. We don't need it anymore\r\nsince it can be supplied as a url param. Currently it's only needed in\r\nthe setup route (`POST /internal/observability_ai_assistant/kb/setup`)","sha":"875313e751e70131185459533bd1bfae74efc32b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200181","number":200181,"mergeCommit":{"message":"Remove `modelId` from config (#200181)\n\nFollow up to https://github.com/elastic/kibana/pull/186499\r\n\r\nThis removes `modelId` from the config file. We don't need it anymore\r\nsince it can be supplied as a url param. Currently it's only needed in\r\nthe setup route (`POST /internal/observability_ai_assistant/kb/setup`)","sha":"875313e751e70131185459533bd1bfae74efc32b"}}]}] BACKPORT--> Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #186499
This removes
modelIdfrom the config file. We don't need it anymore since it can be supplied as a url param. Currently it's only needed in the setup route (POST /internal/observability_ai_assistant/kb/setup)