Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Observability Onboarding] Fix kustomize command (#199758) #200191

Merged
merged 2 commits into from
Nov 14, 2024
Merged

[8.x] [Observability Onboarding] Fix kustomize command (#199758) #200191

merged 2 commits into from
Nov 14, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@flash1293
[Observability Onboarding] Fix kustomize command (elastic#199758)
8c8e95c 
## Summary

Closes elastic#199754 by introducing
more fine-grained version getters to get the base version (to resolve to
the git tag in the repo), the actual version which might include the IAR
suffix and the docker version which replaces + with .

For testing, EA host and kubernetes as well as OTel host should be
tested. See here:
elastic#199758 (comment)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 7ef9773)
@kibanamachine kibanamachine enabled auto-merge (squash) November 14, 2024 14:15
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 14, 2024
@kibanamachine kibanamachine mentioned this pull request Nov 14, 2024
Merged
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 14, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 7bb47c2
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-200191-7bb47c226787

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1298 1300 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 281.0KB 281.2KB +151.0B
Unknown metric groups

API count

id before after diff
fleet 1423 1427 +4

History

cc @flash1293

@kibanamachine kibanamachine merged commit 274e497 into elastic:8.x Nov 14, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@flash1293 flash1293

Labels
backport ci:project-deploy-observability Create an Observability project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @flash1293