[8.x] [Stack Monitoring / Logs] Fix Stack Monitoring logs links (#200043) #200227
+53
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0043) ## Summary Fixes elastic#199902 (comment). This was missed in elastic#190835 due to Stack Monitoring's lack of type checking in certain files. `infra` no longer exposes `logsLocators`. This uses `getLogsLocatorsFromUrlService`, technically we could go to Discover now knowing that Logs Explorer will be deprecated in the future. But it will make more sense to convert `getLogsLocatorsFromUrlService` over to using the Discover locators in one when that happens. This puts us on the same page as elastic#190835. This link should now work, and have the correct filters applied.  --------- Co-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co> (cherry picked from commit 4e852ea)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
Page load bundle
cc @Kerry350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation