Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Stack Monitoring / Logs] Fix Stack Monitoring logs links (#200043) #200227

Merged
merged 1 commit into from
Nov 14, 2024

Commits on Nov 14, 2024

  1. [Stack Monitoring / Logs] Fix Stack Monitoring logs links (elastic#20…

    …0043)
    
    ## Summary
    
    Fixes
    elastic#199902 (comment).
    
    This was missed in elastic#190835 due to
    Stack Monitoring's lack of type checking in certain files. `infra` no
    longer exposes `logsLocators`.
    
    This uses `getLogsLocatorsFromUrlService`, technically we could go to
    Discover now knowing that Logs Explorer will be deprecated in the
    future. But it will make more sense to convert
    `getLogsLocatorsFromUrlService` over to using the Discover locators in
    one when that happens. This puts us on the same page as
    elastic#190835.
    
    This link should now work, and have the correct filters applied.
    
    ![Screenshot 2024-11-13 at 16 09
    15](https://github.com/user-attachments/assets/e1f8fd18-ac73-4179-af4c-1727a2afeeec)
    
    ---------
    
    Co-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co>
    (cherry picked from commit 4e852ea)
    Kerry350 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b35687d View commit details
    Browse the repository at this point in the history