[8.x] [Spaces] Open 'manage roles' link for spaces assign role flyout in new tab (#199506) #200228
+65
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w tab (elastic#199506) ## Summary Closes elastic/kibana-team#1281 Modify the "manage role" link in the assign roles to space tab, so it opens the roles screen in a new tab, with an improvement so that on transitioning back to the assign roles space tab the user is presented with an updated list of roles created in the page that was created opened, if any. Caveat: This approach will continually make calls to refresh the role list on every page visibility event that matches the conditions provided until the flyout gets closed. ##### Visuals https://github.com/user-attachments/assets/64cb296d-246d-4033-a655-7b10d0dafab1 ### Checklist Delete any items that are not applicable to this PR. <!-- - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials --> - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios <!-- - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [ ] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --> (cherry picked from commit 190430b)
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation
\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n","sha":"190430b0b2011235963af069a0196cfafb7a5cd5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","backport:prev-minor","ci:cloud-deploy"],"title":"[Spaces] Open 'manage roles' link for spaces assign role flyout in new tab","number":199506,"url":"https://github.com//pull/199506","mergeCommit":{"message":"[Spaces] Open 'manage roles' link for spaces assign role flyout in new tab (#199506)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana-team/issues/1281\r\n\r\nModify the \"manage role\" link in the assign roles to space tab, so it\r\nopens the roles screen in a new tab, with an improvement so that on\r\ntransitioning back to the assign roles space tab the user is presented\r\nwith an updated list of roles created in the page that was created\r\nopened, if any.\r\n\r\nCaveat:\r\n\r\nThis approach will continually make calls to refresh the role list on\r\nevery page visibility event that matches the conditions provided until\r\nthe flyout gets closed.\r\n\r\n##### Visuals\r\n\r\n\r\nhttps://github.com/user-attachments/assets/64cb296d-246d-4033-a655-7b10d0dafab1\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n","sha":"190430b0b2011235963af069a0196cfafb7a5cd5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com//pull/199506","number":199506,"mergeCommit":{"message":"[Spaces] Open 'manage roles' link for spaces assign role flyout in new tab (#199506)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana-team/issues/1281\r\n\r\nModify the \"manage role\" link in the assign roles to space tab, so it\r\nopens the roles screen in a new tab, with an improvement so that on\r\ntransitioning back to the assign roles space tab the user is presented\r\nwith an updated list of roles created in the page that was created\r\nopened, if any.\r\n\r\nCaveat:\r\n\r\nThis approach will continually make calls to refresh the role list on\r\nevery page visibility event that matches the conditions provided until\r\nthe flyout gets closed.\r\n\r\n##### Visuals\r\n\r\n\r\nhttps://github.com/user-attachments/assets/64cb296d-246d-4033-a655-7b10d0dafab1\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n","sha":"190430b0b2011235963af069a0196cfafb7a5cd5"}}]}] BACKPORT-->