Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Index Management] Add index mode field in index template form (#199521) #200244

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ic#199521)

Closes elastic#198620

## Summary

This PR adds a field for index mode setting in the Logistics step in
Index Template form.

https://github.com/user-attachments/assets/ee38bdec-66ff-468d-a55e-abf5354c3da2

**How to test:**
1. Go to Index Management -> Index Templates and start creating an index
template
2. Verify that the index mode is only enabled if the data stream toggle
is on.
3. Verify that typing the `logs-*-*` index pattern sets the index mode
to "LogsDB":

<img width="1401" alt="Screenshot 2024-11-13 at 13 00 10"
src="https://github.com/user-attachments/assets/d1825d08-5039-4c43-80a8-653233e0b677">

4. Go to the Settings step and verify that the index mode callout is
displayed correctly.
5. Go to Review step and verify that Index mode is displayed correctly
in both the summary and the preview request.
6. Save the template and verify that the template details tab correctly
displays the index mode.

<img width="1565" alt="Screenshot 2024-11-13 at 17 22 54"
src="https://github.com/user-attachments/assets/2055501b-32c9-463c-b61d-541b9687b459">

<img width="1565" alt="Screenshot 2024-11-13 at 17 22 31"
src="https://github.com/user-attachments/assets/21c9cf9e-5858-4403-9106-57ed8ccf3639">

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

(cherry picked from commit 16127fc)
@kibanamachine kibanamachine merged commit 7ef99b3 into elastic:8.x Nov 14, 2024
24 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexManagement 695 696 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
indexManagement 236 238 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 690.5KB 693.5KB +3.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexManagement 46.1KB 46.3KB +287.0B
Unknown metric groups

API count

id before after diff
indexManagement 241 243 +2

cc @ElenaStoeva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants