-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDR Workflows] Workflow Insights - RBAC #205088
Merged
Merged
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2ae68bd
rbac
szwarckonrad 87d6f09
Merge branch 'main' into workflow-insights-rbac
szwarckonrad 5297d88
rbac
szwarckonrad b38f206
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 87e7f02
skip cypress for now
szwarckonrad a37b644
Merge remote-tracking branch 'origin/workflow-insights-rbac' into wor…
szwarckonrad 837f1a3
Merge branch 'main' into workflow-insights-rbac
szwarckonrad 7418c96
Merge branch 'main' into workflow-insights-rbac
szwarckonrad cb1921b
Merge branch 'main' into workflow-insights-rbac
szwarckonrad e6daa95
merge
szwarckonrad 5f752ea
Merge branch 'main' into workflow-insights-rbac
joeypoon 89e5c88
Merge branch 'main' into workflow-insights-rbac
joeypoon db3ba39
Merge branch 'main' into workflow-insights-rbac
joeypoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,7 +28,7 @@ export const getDefendInsightsRoute = (router: IRouter<ElasticAssistantRequestHa | |
path: DEFEND_INSIGHTS, | ||
security: { | ||
authz: { | ||
requiredPrivileges: ['elasticAssistant'], | ||
requiredPrivileges: ['securitySolution-readWorkflowInsights'], | ||
}, | ||
}, | ||
}) | ||
|
@@ -48,8 +48,12 @@ export const getDefendInsightsRoute = (router: IRouter<ElasticAssistantRequestHa | |
}, | ||
async (context, request, response): Promise<IKibanaResponse<DefendInsightsGetResponse>> => { | ||
const resp = buildResponse(response); | ||
const assistantContext = await context.elasticAssistant; | ||
|
||
const ctx = await context.resolve(['licensing', 'elasticAssistant']); | ||
|
||
const assistantContext = ctx.elasticAssistant; | ||
const logger: Logger = assistantContext.logger; | ||
|
||
try { | ||
const isEnabled = isDefendInsightsEnabled({ | ||
request, | ||
|
@@ -60,6 +64,15 @@ export const getDefendInsightsRoute = (router: IRouter<ElasticAssistantRequestHa | |
return response.notFound(); | ||
} | ||
|
||
if (!ctx.licensing.license.hasAtLeast('enterprise')) { | ||
return response.forbidden({ | ||
body: { | ||
message: | ||
'Your license does not support Defend Workflows. Please upgrade your license.', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And this? |
||
}, | ||
}); | ||
} | ||
|
||
const dataClient = await assistantContext.getDefendInsightsDataClient(); | ||
|
||
const authenticatedUser = assistantContext.getCurrentUser(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be in i18n?