Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] List all policies to display integrations properly #205103

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jkelas
Copy link
Contributor

@jkelas jkelas commented Dec 23, 2024

Resolves: #200167

Summary

Increase number of fetched package policies to the maximum. Currently only the first 20 policies (the first page) are returned, which results in treating all remaining ones as disabled.
I am proposing the simplest change of increasing the limit here to the maximum. There shouldn't be too many policies there, e.g. in the reproduction I am running there are 23 instead of 20.
If that is not enough, however, the alternative would be to discover that there are more policies than the specified limit and the next page(s) would have to be collected and the results added to the final list.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@jkelas jkelas added bug Fixes for quality problems that affect the customer experience release_note:fix Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area backport:version Backport to applied version labels 8.18 candidate 9.0 candidate v8.16.3 v8.17.1 labels Dec 23, 2024
@jkelas jkelas self-assigned this Dec 23, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 23, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@jkelas jkelas changed the title List all policies to display integrations properly [Security Solution] List all policies to display integrations properly Dec 23, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / useActionStatus should set action statuses on init

Metrics [docs]

✅ unchanged

cc @jkelas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.18 candidate 9.0 candidate backport:version Backport to applied version labels bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:fix Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.3 v8.17.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Solution] Rule integrations are displayed disabled while being enabled
2 participants