-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-presentation (#204843) #205120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
nickpeihl
force-pushed
the
backport/8.x/pr-204843
branch
from
December 23, 2024 21:10
bd76bc5
to
b39c55d
Compare
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
|
jsanz
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.
Important
packages[\/\\]
andplugins[\/\\]
patterns in the source code (Babel and Eslint config files), and update them appropriately..buildkite/scripts/pipelines/pull_request/pipeline.ts
to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names.ts
and.js
files listed in the sections below, as some of them contain relative paths that have been updated.Note
Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.
21 plugin(s) are going to be relocated:
@kbn/canvas-plugin
x-pack/platform/plugins/private/canvas
@kbn/controls-plugin
src/platform/plugins/shared/controls
@kbn/dashboard-enhanced-plugin
x-pack/platform/plugins/shared/dashboard_enhanced
@kbn/dashboard-plugin
src/platform/plugins/shared/dashboard
@kbn/embeddable-enhanced-plugin
x-pack/platform/plugins/shared/embeddable_enhanced
@kbn/embeddable-plugin
src/platform/plugins/shared/embeddable
@kbn/expression-error-plugin
src/platform/plugins/shared/expression_error
@kbn/expression-image-plugin
src/platform/plugins/shared/expression_image
@kbn/expression-metric-plugin
src/platform/plugins/shared/expression_metric
@kbn/expression-repeat-image-plugin
src/platform/plugins/shared/expression_repeat_image
@kbn/expression-reveal-image-plugin
src/platform/plugins/shared/expression_reveal_image
@kbn/expression-shape-plugin
src/platform/plugins/shared/expression_shape
@kbn/file-upload-plugin
x-pack/platform/plugins/private/file_upload
@kbn/input-control-vis-plugin
src/platform/plugins/private/input_control_vis
@kbn/inspector-plugin
src/platform/plugins/shared/inspector
@kbn/links-plugin
src/platform/plugins/private/links
@kbn/maps-ems-plugin
src/platform/plugins/private/maps_ems
@kbn/maps-plugin
x-pack/platform/plugins/shared/maps
@kbn/presentation-panel-plugin
src/platform/plugins/private/presentation_panel
@kbn/presentation-util-plugin
src/platform/plugins/shared/presentation_util
@kbn/vis-type-markdown-plugin
src/platform/plugins/private/vis_type_markdown
3 packages(s) are going to be relocated:
@kbn/panel-loader
src/platform/packages/private/kbn-panel-loader
@kbn/presentation-containers
src/platform/packages/shared/presentation/presentation_containers
@kbn/presentation-publishing
src/platform/packages/shared/presentation/presentation_publishing
Updated references
Updated relative paths