[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-presentation (#204843)

.buildkite/scripts/pipelines/pull_request/pipeline.ts

@@ -317,12 +317,12 @@ const getPipeline = (filename: string, removeSteps = true) => {
         /^packages\/shared-ux/,
         /^src\/core/,
         /^src\/plugins\/charts/,
-        /^src\/plugins\/controls/,
+        /^src\/platform\/plugins\/shared\/controls/,
         /^src\/plugins\/data/,
         /^src\/plugins\/data_views/,
         /^src\/plugins\/discover/,
         /^src\/plugins\/field_formats/,
-        /^src\/plugins\/inspector/,
+        /^src\/platform\/plugins\/shared\/inspector/,
         /^src\/plugins\/kibana_react/,
         /^src\/plugins\/kibana_utils/,
         /^src\/plugins\/saved_search/,

.eslintignore

@@ -22,9 +22,9 @@ snapshots.js
 # plugin overrides
 /src/core/lib/kbn_internal_native_observable
 /src/plugins/data/common/es_query/kuery/ast/_generated_/**
-/x-pack/plugins/canvas/canvas_plugin
-/x-pack/plugins/canvas/shareable_runtime/build
-/x-pack/plugins/canvas/storybook/build
+/x-pack/platform/plugins/private/canvas/canvas_plugin
+/x-pack/platform/plugins/private/canvas/shareable_runtime/build
+/x-pack/platform/plugins/private/canvas/storybook/build
 /x-pack/plugins/reporting/server/export_types/printable_pdf/server/lib/pdf/assets/**
 /x-pack/plugins/reporting/server/export_types/printable_pdf_v2/server/lib/pdf/assets/**
 /x-pack/plugins/cloud_integrations/cloud_full_story/server/assets/**

.eslintrc.js

@@ -296,7 +296,7 @@ module.exports = {
       },
     },
     {
-      files: ['x-pack/plugins/canvas/**/*.{js,mjs,ts,tsx}'],
+      files: ['x-pack/platform/plugins/private/canvas/**/*.{js,mjs,ts,tsx}'],
       rules: {
         'jsx-a11y/click-events-have-key-events': 'off',
       },
@@ -1692,7 +1692,7 @@ module.exports = {
      * Canvas overrides
      */
     {
-      files: ['x-pack/plugins/canvas/**/*.js'],
+      files: ['x-pack/platform/plugins/private/canvas/**/*.js'],
       rules: {
         radix: 'error',
 
@@ -1736,12 +1736,12 @@ module.exports = {
     },
     {
       files: [
-        'x-pack/plugins/canvas/gulpfile.js',
-        'x-pack/plugins/canvas/scripts/*.js',
-        'x-pack/plugins/canvas/tasks/*.js',
-        'x-pack/plugins/canvas/tasks/**/*.js',
-        'x-pack/plugins/canvas/__tests__/**/*.js',
-        'x-pack/plugins/canvas/**/{__tests__,__test__,__jest__,__fixtures__,__mocks__}/**/*.js',
+        'x-pack/platform/plugins/private/canvas/gulpfile.js',
+        'x-pack/platform/plugins/private/canvas/scripts/*.js',
+        'x-pack/platform/plugins/private/canvas/tasks/*.js',
+        'x-pack/platform/plugins/private/canvas/tasks/**/*.js',
+        'x-pack/platform/plugins/private/canvas/__tests__/**/*.js',
+        'x-pack/platform/plugins/private/canvas/**/{__tests__,__test__,__jest__,__fixtures__,__mocks__}/**/*.js',
       ],
       rules: {
         'import/no-extraneous-dependencies': [
@@ -1755,11 +1755,11 @@ module.exports = {
       },
     },
     {
-      files: ['x-pack/plugins/canvas/canvas_plugin_src/**/*.js'],
+      files: ['x-pack/platform/plugins/private/canvas/canvas_plugin_src/**/*.js'],
       globals: { canvas: true, $: true },
     },
     {
-      files: ['x-pack/plugins/canvas/public/**/*.js'],
+      files: ['x-pack/platform/plugins/private/canvas/public/**/*.js'],
       env: {
         browser: true,
       },

.github/CODEOWNERS

@@ -65,7 +65,7 @@ examples/bfetch_explorer @elastic/appex-sharedux
 src/plugins/bfetch @elastic/appex-sharedux
 packages/kbn-calculate-auto @elastic/obs-ux-management-team
 packages/kbn-calculate-width-from-char-count @elastic/kibana-visualizations
-x-pack/plugins/canvas @elastic/kibana-presentation
+x-pack/platform/plugins/private/canvas @elastic/kibana-presentation
 packages/kbn-capture-oas-snapshot-cli @elastic/kibana-core
 x-pack/test/cases_api_integration/common/plugins/cases @elastic/response-ops
 packages/kbn-cases-components @elastic/response-ops
@@ -118,7 +118,7 @@ packages/content-management/table_list_view_table @elastic/appex-sharedux
 packages/content-management/user_profiles @elastic/appex-sharedux
 packages/kbn-content-management-utils @elastic/kibana-data-discovery
 examples/controls_example @elastic/kibana-presentation
-src/plugins/controls @elastic/kibana-presentation
+src/platform/plugins/shared/controls @elastic/kibana-presentation
 src/core @elastic/kibana-core
 src/core/packages/analytics/browser @elastic/kibana-core
 src/core/packages/analytics/browser-internal @elastic/kibana-core
@@ -351,8 +351,8 @@ packages/kbn-custom-icons @elastic/obs-ux-logs-team
 packages/kbn-custom-integrations @elastic/obs-ux-logs-team
 src/plugins/custom_integrations @elastic/fleet
 packages/kbn-cypress-config @elastic/kibana-operations
-x-pack/plugins/dashboard_enhanced @elastic/kibana-presentation
-src/plugins/dashboard @elastic/kibana-presentation
+x-pack/platform/plugins/shared/dashboard_enhanced @elastic/kibana-presentation
+src/platform/plugins/shared/dashboard @elastic/kibana-presentation
 x-pack/platform/packages/shared/kbn-data-forge @elastic/obs-ux-management-team
 src/plugins/data @elastic/kibana-visualizations @elastic/kibana-data-discovery
 x-pack/plugins/data_quality @elastic/obs-ux-logs-team
@@ -407,9 +407,9 @@ x-pack/platform/packages/shared/kbn-elastic-assistant-common @elastic/security-g
 x-pack/solutions/security/plugins/elastic_assistant @elastic/security-generative-ai
 test/plugin_functional/plugins/elasticsearch_client_plugin @elastic/kibana-core
 x-pack/test/plugin_api_integration/plugins/elasticsearch_client @elastic/kibana-core
-x-pack/plugins/embeddable_enhanced @elastic/kibana-presentation
+x-pack/platform/plugins/shared/embeddable_enhanced @elastic/kibana-presentation
 examples/embeddable_examples @elastic/kibana-presentation
-src/plugins/embeddable @elastic/kibana-presentation
+src/platform/plugins/shared/embeddable @elastic/kibana-presentation
 x-pack/examples/embedded_lens_example @elastic/kibana-visualizations
 x-pack/plugins/encrypted_saved_objects @elastic/kibana-security
 x-pack/plugins/enterprise_search @elastic/search-kibana
@@ -453,17 +453,17 @@ x-pack/solutions/security/packages/expandable-flyout @elastic/security-threat-hu
 packages/kbn-expect @elastic/kibana-operations @elastic/appex-qa
 x-pack/examples/exploratory_view_example @elastic/obs-ux-infra_services-team
 x-pack/solutions/observability/plugins/exploratory_view @elastic/obs-ux-management-team
-src/plugins/expression_error @elastic/kibana-presentation
+src/platform/plugins/shared/expression_error @elastic/kibana-presentation
 src/plugins/chart_expressions/expression_gauge @elastic/kibana-visualizations
 src/plugins/chart_expressions/expression_heatmap @elastic/kibana-visualizations
-src/plugins/expression_image @elastic/kibana-presentation
+src/platform/plugins/shared/expression_image @elastic/kibana-presentation
 src/plugins/chart_expressions/expression_legacy_metric @elastic/kibana-visualizations
-src/plugins/expression_metric @elastic/kibana-presentation
+src/platform/plugins/shared/expression_metric @elastic/kibana-presentation
 src/plugins/chart_expressions/expression_metric @elastic/kibana-visualizations
 src/plugins/chart_expressions/expression_partition_vis @elastic/kibana-visualizations
-src/plugins/expression_repeat_image @elastic/kibana-presentation
-src/plugins/expression_reveal_image @elastic/kibana-presentation
-src/plugins/expression_shape @elastic/kibana-presentation
+src/platform/plugins/shared/expression_repeat_image @elastic/kibana-presentation
+src/platform/plugins/shared/expression_reveal_image @elastic/kibana-presentation
+src/platform/plugins/shared/expression_shape @elastic/kibana-presentation
 src/plugins/chart_expressions/expression_tagcloud @elastic/kibana-visualizations
 src/plugins/chart_expressions/expression_xy @elastic/kibana-visualizations
 examples/expressions_explorer @elastic/kibana-visualizations
@@ -480,7 +480,7 @@ src/plugins/field_formats @elastic/kibana-data-discovery
 packages/kbn-field-types @elastic/kibana-data-discovery
 packages/kbn-field-utils @elastic/kibana-data-discovery
 x-pack/plugins/fields_metadata @elastic/obs-ux-logs-team
-x-pack/plugins/file_upload @elastic/kibana-presentation @elastic/ml-ui
+x-pack/platform/plugins/private/file_upload @elastic/kibana-presentation @elastic/ml-ui
 examples/files_example @elastic/appex-sharedux
 src/plugins/files_management @elastic/appex-sharedux
 src/plugins/files @elastic/appex-sharedux
@@ -539,8 +539,8 @@ x-pack/platform/plugins/shared/inference @elastic/appex-ai-infra
 x-pack/platform/packages/private/kbn-infra-forge @elastic/obs-ux-management-team
 x-pack/plugins/observability_solution/infra @elastic/obs-ux-logs-team @elastic/obs-ux-infra_services-team
 x-pack/platform/plugins/shared/ingest_pipelines @elastic/kibana-management
-src/plugins/input_control_vis @elastic/kibana-presentation
-src/plugins/inspector @elastic/kibana-presentation
+src/platform/plugins/private/input_control_vis @elastic/kibana-presentation
+src/platform/plugins/shared/inspector @elastic/kibana-presentation
 x-pack/platform/plugins/shared/integration_assistant @elastic/security-scalability
 src/plugins/interactive_setup @elastic/kibana-security
 test/interactive_setup_api_integration/plugins/test_endpoints @elastic/kibana-security
@@ -578,7 +578,7 @@ x-pack/plugins/lens @elastic/kibana-visualizations
 x-pack/platform/plugins/private/license_api_guard @elastic/kibana-management
 x-pack/platform/plugins/shared/license_management @elastic/kibana-management
 x-pack/plugins/licensing @elastic/kibana-core
-src/plugins/links @elastic/kibana-presentation
+src/platform/plugins/private/links @elastic/kibana-presentation
 packages/kbn-lint-packages-cli @elastic/kibana-operations
 packages/kbn-lint-ts-projects-cli @elastic/kibana-operations
 x-pack/solutions/security/plugins/lists @elastic/security-detection-engine
@@ -611,8 +611,8 @@ test/plugin_functional/plugins/management_test_plugin @elastic/kibana-management
 packages/kbn-manifest @elastic/kibana-core
 packages/kbn-mapbox-gl @elastic/kibana-gis
 x-pack/examples/third_party_maps_source_example @elastic/kibana-gis
-src/plugins/maps_ems @elastic/kibana-presentation
-x-pack/plugins/maps @elastic/kibana-presentation
+src/platform/plugins/private/maps_ems @elastic/kibana-presentation
+x-pack/platform/plugins/shared/maps @elastic/kibana-presentation
 x-pack/packages/maps/vector_tile_utils @elastic/kibana-gis
 x-pack/plugins/observability_solution/metrics_data_access @elastic/obs-ux-infra_services-team
 x-pack/platform/packages/private/ml/agg_utils @elastic/ml-ui
@@ -691,7 +691,7 @@ src/platform/packages/shared/kbn-osquery-io-ts-types @elastic/security-asset-man
 x-pack/platform/plugins/shared/osquery @elastic/security-defend-workflows
 examples/partial_results_example @elastic/kibana-data-discovery
 x-pack/platform/plugins/private/painless_lab @elastic/kibana-management
-packages/kbn-panel-loader @elastic/kibana-presentation
+src/platform/packages/private/kbn-panel-loader @elastic/kibana-presentation
 packages/kbn-peggy @elastic/kibana-operations
 packages/kbn-peggy-loader @elastic/kibana-operations
 packages/kbn-performance-testing-dataset-extractor @elastic/kibana-performance-testing
@@ -701,10 +701,10 @@ packages/kbn-plugin-generator @elastic/kibana-operations
 packages/kbn-plugin-helpers @elastic/kibana-operations
 examples/portable_dashboards_example @elastic/kibana-presentation
 examples/preboot_example @elastic/kibana-security @elastic/kibana-core
-packages/presentation/presentation_containers @elastic/kibana-presentation
-src/plugins/presentation_panel @elastic/kibana-presentation
-packages/presentation/presentation_publishing @elastic/kibana-presentation
-src/plugins/presentation_util @elastic/kibana-presentation
+src/platform/packages/shared/presentation/presentation_containers @elastic/kibana-presentation
+src/platform/plugins/private/presentation_panel @elastic/kibana-presentation
+src/platform/packages/shared/presentation/presentation_publishing @elastic/kibana-presentation
+src/platform/plugins/shared/presentation_util @elastic/kibana-presentation
 x-pack/packages/ai-infra/product-doc-artifact-builder @elastic/appex-ai-infra
 x-pack/platform/plugins/shared/ai_infra/product_doc_base @elastic/appex-ai-infra
 x-pack/platform/packages/shared/ai-infra/product-doc-common @elastic/appex-ai-infra
@@ -1020,7 +1020,7 @@ packages/kbn-validate-next-docs-cli @elastic/kibana-operations
 src/plugins/vis_default_editor @elastic/kibana-visualizations
 src/plugins/vis_types/gauge @elastic/kibana-visualizations
 src/plugins/vis_types/heatmap @elastic/kibana-visualizations
-src/plugins/vis_type_markdown @elastic/kibana-presentation
+src/platform/plugins/private/vis_type_markdown @elastic/kibana-presentation
 src/plugins/vis_types/metric @elastic/kibana-visualizations
 src/plugins/vis_types/pie @elastic/kibana-visualizations
 src/plugins/vis_types/table @elastic/kibana-visualizations
@@ -1334,13 +1334,13 @@ x-pack/test_serverless/**/test_suites/observability/ai_assistant @elastic/obs-ai
 /x-pack/test/functional_basic/apps/transform/ @elastic/ml-ui
 
 # Maps
-#CC# /x-pack/plugins/maps/ @elastic/kibana-gis
+#CC# /x-pack/platform/plugins/shared/maps/ @elastic/kibana-gis
 /x-pack/test/api_integration/apis/maps/ @elastic/kibana-gis
 /x-pack/test/functional/apps/maps/ @elastic/kibana-gis
 /x-pack/test/functional/es_archives/maps/ @elastic/kibana-gis
 /x-pack/plugins/stack_alerts/server/rule_types/geo_containment @elastic/kibana-gis
 /x-pack/plugins/stack_alerts/public/rule_types/geo_containment @elastic/kibana-gis
-#CC# /x-pack/plugins/file_upload @elastic/kibana-gis
+#CC# /x-pack/platform/plugins/private/file_upload @elastic/kibana-gis
 
 # Operations
 /src/dev/license_checker/config.ts @elastic/kibana-operations

.github/codeql/codeql-config.yml

@@ -73,7 +73,7 @@ paths-ignore:
   - packages/kbn-yarn-lock-validator
   - scripts
   - test
-  - x-pack/plugins/canvas/scripts
+  - x-pack/platform/plugins/private/canvas/scripts
   - x-pack/solutions/security/plugins/cloud_security_posture/common/scripts
   - x-pack/solutions/security/plugins/elastic_assistant/scripts
   - x-pack/plugins/event_log/scripts

.github/paths-labeller.yml

@@ -1,10 +1,10 @@
 ---
 - 'Feature:Embedding':
-    - 'src/plugins/embeddable/**/*.*'
+    - 'src/platform/plugins/shared/embeddable/**/*.*'
     - 'src/plugins/dashboard_embeddable_container/**/*.*'
 - 'Feature:Drilldowns':
     - 'x-pack/plugins/drilldowns/**/*.*'
-    - 'x-pack/plugins/dashboard_enhanced/public/services/drilldowns/**/*.*'
+    - 'x-pack/platform/plugins/shared/dashboard_enhanced/public/services/drilldowns/**/*.*'
 - 'Feature:ExpressionLanguage':
     - 'src/plugins/expressions/**/*.*'
     - 'src/plugins/bfetch/**/*.*'

.i18nrc.json

@@ -18,10 +18,10 @@
     "core": ["src/core", "packages/core"],
     "customIntegrations": "src/plugins/custom_integrations",
     "customIntegrationsPackage": "packages/kbn-custom-integrations",
-    "dashboard": "src/plugins/dashboard",
+    "dashboard": "src/platform/plugins/shared/dashboard",
     "cloud": "packages/cloud",
     "domDragDrop": "packages/kbn-dom-drag-drop",
-    "controls": "src/plugins/controls",
+    "controls": "src/platform/plugins/shared/controls",
     "data": "src/plugins/data",
     "observabilityAlertDetails": "x-pack/solutions/observability/packages/alert_details",
     "dataViews": "src/plugins/data_views",
@@ -33,26 +33,26 @@
       "packages/kbn-discover-contextual-components"
     ],
     "savedSearch": "src/plugins/saved_search",
-    "embeddableApi": "src/plugins/embeddable",
-    "presentationPanel": "src/plugins/presentation_panel",
+    "embeddableApi": "src/platform/plugins/shared/embeddable",
+    "presentationPanel": "src/platform/plugins/private/presentation_panel",
     "embeddableExamples": "examples/embeddable_examples",
     "esQuery": "packages/kbn-es-query/src",
     "kbnGridLayout": "packages/kbn-grid-layout",
     "esUi": "src/platform/plugins/shared/es_ui_shared",
     "expandableFlyout": "packages/kbn-expandable-flyout",
-    "expressionError": "src/plugins/expression_error",
+    "expressionError": "src/platform/plugins/shared/expression_error",
     "expressionGauge": "src/plugins/chart_expressions/expression_gauge",
     "expressionHeatmap": "src/plugins/chart_expressions/expression_heatmap",
-    "expressionImage": "src/plugins/expression_image",
-    "expressionMetric": "src/plugins/expression_metric",
+    "expressionImage": "src/platform/plugins/shared/expression_image",
+    "expressionMetric": "src/platform/plugins/shared/expression_metric",
     "expressionMetricVis": "src/plugins/chart_expressions/expression_metric",
     "expressionLegacyMetricVis": "src/plugins/chart_expressions/expression_legacy_metric",
     "expressionPartitionVis": "src/plugins/chart_expressions/expression_partition_vis",
     "expressionXY": "src/plugins/chart_expressions/expression_xy",
-    "expressionRepeatImage": "src/plugins/expression_repeat_image",
-    "expressionRevealImage": "src/plugins/expression_reveal_image",
+    "expressionRepeatImage": "src/platform/plugins/shared/expression_repeat_image",
+    "expressionRevealImage": "src/platform/plugins/shared/expression_reveal_image",
     "expressions": "src/plugins/expressions",
-    "expressionShape": "src/plugins/expression_shape",
+    "expressionShape": "src/platform/plugins/shared/expression_shape",
     "expressionTagcloud": "src/plugins/chart_expressions/expression_tagcloud",
     "eventAnnotation": "src/plugins/event_annotation",
     "eventAnnotationListing": "src/plugins/event_annotation_listing",
@@ -73,8 +73,8 @@
     "indexPatternEditor": "src/plugins/data_view_editor",
     "indexPatternFieldEditor": "src/plugins/data_view_field_editor",
     "indexPatternManagement": "src/plugins/data_view_management",
-    "inputControl": "src/plugins/input_control_vis",
-    "inspector": "src/plugins/inspector",
+    "inputControl": "src/platform/plugins/private/input_control_vis",
+    "inspector": "src/platform/plugins/shared/inspector",
     "inspectorViews": "src/legacy/core_plugins/inspector_views",
     "interactiveSetup": "src/plugins/interactive_setup",
     "interpreter": "src/legacy/core_plugins/interpreter",
@@ -98,9 +98,9 @@
     ],
     "monaco": "packages/kbn-monaco/src",
     "navigation": ["src/plugins/navigation", "packages/solution-nav"],
-    "links": "src/plugins/links",
+    "links": "src/platform/plugins/private/links",
     "newsfeed": "src/plugins/newsfeed",
-    "presentationUtil": "src/plugins/presentation_util",
+    "presentationUtil": "src/platform/plugins/shared/presentation_util",
     "randomSampling": "x-pack/packages/kbn-random-sampling",
     "reactPackages": "packages/react",
     "esqlEditor": "src/platform/packages/private/kbn-esql-editor",
@@ -149,7 +149,7 @@
     "visDefaultEditor": "src/plugins/vis_default_editor",
     "visTypeGauge": "src/plugins/vis_types/gauge",
     "visTypeHeatmap": "src/plugins/vis_types/heatmap",
-    "visTypeMarkdown": "src/plugins/vis_type_markdown",
+    "visTypeMarkdown": "src/platform/plugins/private/vis_type_markdown",
     "visTypeMetric": "src/plugins/vis_types/metric",
     "visTypePie": "src/plugins/vis_types/pie",
     "visTypeTable": "src/plugins/vis_types/table",

docs/developer/best-practices/index.asciidoc

@@ -78,7 +78,7 @@ strategies]
 *** Use the `esSearchStrategy` to make raw queries to ES that will
 support async searching and partial results, as well as injecting the
 right advanced settings like whether to include frozen indices or not.
-* {kib-repo}blob/{branch}/src/plugins/embeddable/README.md[Embeddables]
+* {kib-repo}blob/{branch}/src/platform/plugins/shared/embeddable/README.md[Embeddables]
 ** Rendering maps, visualizations, dashboards in your application
 ** Register new widgets that will can be added to a dashboard or Canvas
 workpad, or rendered in another plugin.