Upgrade EUI to v23.3.1 #65877

thompsongl · 2020-05-08T15:36:41Z

Summary

v22.3.1 ⏩ v23.3.1

EUI components are 100% TypeScript 🎉
TypeScript updated to v3.7.2
Jest environment component mocks for EuiCode and EuiCodeBlock
Various methods of ID generation consolidated to a single htmlIdGenerator util
EuiIcon has a caching layer to prevent rerender flashes/flickers
EuiColorPicker at functional parity with TSVB picker
New EuiTour components
New EuiResizableContainer component
New EuiComment and EuiCommentList components
Components that support href now also set rel

`23.3.1`

Bug Fixes

Fixed EuiSuperDatePicker quick selection menu overriding specified time range with default values (#3446)
Fixed EuiDatePopoverContent onChange event to only accept string date input (#3460)

`23.3.0`

Added aria-hidden = true to EuiRangeSlider and EuiRangeTrack if showInput = true (#3423)
Added testenv mock for EuiCode and EuiCodeBlock (#3405)
Added displayName to components using React.forwardRef (#3440)

Bug Fixes

Fixed EuiCode and EuiCodeBlock from erroring in environments without a DOM implementation (#3405)
Fixed ApplyClassComponentDefaults typescript utility to correctly determine defaulted properties' types (#3430)
Fixed prettyDuration return type to be string, use fallback value (#3438)

`23.2.0`

Added iconType prop to EuiDatePicker (#3383)
Applied max-width: 100% to EuiPageBody so inner flex-based items don't overflow their containers (#3375)
Added titleSize prop to EuiStep and EuiSteps (#3340)
Handled ref passed to EuiHeaderSectionItemButton (#3378)
Added iconProps prop to EuiCollapsibleNavGroup to extend the props passed to the rendered EuiIcon (#3365)
Added closeButtonProps to EuiCollapsibleNav (#3398)
Added buffer prop to EuiPopover for altering minimum distance to container edges (#3398)
Allowed search prop changes to update EuiInMemoryTable internal query state (#3371)
Added EuiResizableContainer component (#2701)
Added caching layer on EuiIcon to prevent delays and flickering when rendering an already fetched icon (#3404)

Bug Fixes

Fixed EuiFieldSearch to trigger onSearch single time instead of two times (#3425)
Fixed EuiBasicTable item selection when id is 0 (#3417)
Fixed EuiNavDrawer not closing on outside click after being unlocked (#3415)
Fixed EuiBadge iconOnClick props makes badge text clickable (#3392)
Added id requirement if label is used in EuiRadio (#3382)
Fixed z-index issue in EuiDatePicker where it's popover would sit beneath other DOM siblings that had z-index applied (#3376)
Added download glyph to EuiIcon (#3364)
Applies max-width: 100% to EuiPageBody so inner flex-based items don't overflow their containers (#3375)
Added ReactElement to EuiCard image prop type to allow custom component (#3370)
Fixed EuiCollapsibleNavGroup titleSize prop type to properly exclude l and m sizes (#3365)
Fixed EuiDatePickerRange start date popover to sit left under the icon (#3383)
Fixed euiFormControlIsLoading SASS mixin to prevent the loading icon from overlapping with the text when the form control is compressed and adjusted the amount of padding (#3401
Fixed EuiHeader z-index issues with popovers and added body classes for the presence of EuiFlyout and EuiCollapsibleNav.isOpen (#3398)
Fixed EuiInMemoryTable data reset when filter is set and item is selected (#3419)
Fixed popoverPlacement default value for EuiDatePicker (#3427)

`23.1.0`

Removed additional padding applied to $euiHeaderHeightCompensation when EuiHeader is fixed (#3369)

Bug Fixes

Fixed EuiDescribedFormGroup issue that prevented it from shrinking down properly in smaller viewports (#3369)

`23.0.0`

Added showCloseButton and dockedBreakpoint flexibility to EuiCollapsibleNav (#3330)
Added panelStyle prop to EuiPopover to distinguish style object configuration (#3329)
Added popoverPlacement prop in EuiDatePicker (#3359)
Extended EuiDatePicker's startDate and endDate types to accept null values for better interoperability (#3343)
Added EuiCommentList component (#3344)
Added secondary color value input element to EuiColorPicker (#3336)

Bug Fixes

Fixed EuiInMemoryTable isClearable property to initiate reset (#3328)
Removed schema attribute form <input/> in EuiInMemoryTable (#3337)
Fixed EuiCollapsibleNav docked states on mobile (#3330)
Fixed EuiPopover positioning from being overridden by style prop (#3329)
Fixed EuiCodeBlock not copying updated content (#3351)
Fixed alignment of popover of end date of EuiDatePickerRange (#3359)

Breaking changes

Upgraded TypeScript to 3.7.2 (#3295)
Changed EuiCollapsibleNav prop name from hideButtonIfDocked to showButtonIfDocked and flipped default (#3330)

`22.6.0`

Converted NavDrawer, NavDrawerGroup, and NavDrawerFlyout to TypeScript (#3268)
Converted EuiDatePicker, EuiDatePickerRange, EuiSuperDatePicker, and EuiSuperUpdateButton to TypeScript (#2891)
Improved condensed EuiTabs focus states (#3299)
Added EuiTour, EuiTourStep, and useEuiTour components (#2766)
Added EuiBeacon component (#2766)
Added offset and arrowChildren props to EuiPopover for anchor element customization (#2766)

Bug Fixes

Fixed EuiProgress max property to allow undefined (#3198)

`22.5.0`

Added forceState prop to control EuiAccordion state from outside (#3240)

Bug Fixes

Fixed EuiI8n hasPropName utility errors on null values (#3303)
Fixed the inline styles being overwritten by consumer-passed inline styles in EuiBadge (#3284)

`22.4.0`

Added support for href, onClick, and related props in EuiBasicTable default actions (#3115)
Added support for EuiCodeEditor to set readonly and id on <textarea /> (#3212)
Added EuiComment component (#3179)

Deprecation

Updated makeId to DEPRECATED, shifted all the calls to htmlIdGenerator (#3129)

Bug Fixes

Fixed EuiTabbedContent focus discrepancy between selected and initialFocus tabs (#3285)
Fixed the initialSelectedTab prop of EuiTabbedContent to not steal focus from content. Which fixed the bug in EuiSuperDatePicker that required two clicks to focus input in relative tab (#3154)
Fixed the img element in EuiIcon using custom SVGs to have an alt attribute with an empty string, rather than no alt attribute at all (#3245)
Added overflows to EuiDataGrid toolbar dropdowns when there are many columns (#3238)
Fixed EuiIcon's icon type definition to allow custom React components (#3252)
Fixed initialSelectedTab properties used in EuiDatePopoverContent (#3254)
Fixed EuiSideNavItem overriding custom className of item and icon (#3283)
Fixed EuiFieldSearch clear button inconsistencies (#3270)
Fixed components with href usage of rel (#3258)

src/core/public/chrome/ui/header/header.tsx

src/core/public/chrome/ui/header/nav_link.tsx

cjcenizal

ES UI changes LGTM. Thanks for doing this!

spalger

Operations: kbn-ui-shared update LGTM

pgayvallet

LGTM for platform changes

flash1293 · 2020-05-18T08:04:04Z

src/plugins/discover/public/application/components/doc_viewer/doc_viewer.tsx

@@ -35,7 +35,7 @@ export function DocViewer(renderProps: DocViewRenderProps) {
    .getDocViewsSorted(renderProps.hit)
    .map(({ title, render, component }: DocView, idx: number) => {
      return {
-        id: title,
+        id: `kbn_doc_viewer_tab_${idx}`,


Why was this change introduced? Generally it's better to not use the array position for these kind of identifiers. They will be reused when the array changes which can cause unexpected behavior. If there are uniqueness-concerns we could use both (kbn_doc_viewer_tab_${idx}_${title})

EUI now uses id as a DOM selector and these titles are not valid. We could remove spaces or otherwise transform the title string. Would that be preferable?

Makes sense, thanks for the explanation. I checked the code and it's not possible this particular array while change on the fly, so I think it's fine leaving it like this for now - no need to mess around with the title. If it would have been simple it would be preferable to not use the index, but no big deal.

patrykkopycinski

SIEM changes look good, Thank you!

flash1293

Kibana App changes LGTM, code review only

shahzad31

For Fixed EuiFieldSearch clear button inconsistencies (#3270)
Seems like Clear button is displaying now, but it's position isn't alright, it's in the middle. see in below screen above table.

elasticmachine · 2020-05-18T21:39:06Z

Pinging @elastic/uptime (Team:uptime)

thompsongl · 2020-05-18T21:41:34Z

Seems like Clear button is displaying now, but it's position isn't alright, it's in the middle. see in below screen above table.

@shahzad31 I updated the search field using a different layout approach. EuiFieldSearch is composed of a few different elements and setting a width via styled-components doesn't work well.
Used the full width option and limited size via a wrapping div. Handles responsive sizing better now, also.

shahzad31

LGTM !!

lizozom

LGTM

jonathan-buttner

Endpoint changes look good.

igoristic

Looks good from Stack Monitoring pov 👍

thompsongl · 2020-05-21T16:40:10Z

Google Cloud Storage timeout

jenkins test this

kibanamachine · 2020-05-21T18:37:00Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 2316573

History

💚 Build #49134 succeeded 7de00c6
💚 Build #48948 succeeded e803b97
💚 Build #48781 succeeded 7bd47f4
💚 Build #48649 succeeded 11b2924
💔 Build #48488 failed 39f194e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

poffdeluxe

Canvas lgtm

* eui to 23.2.0 * nav drawer ts updates * eui to 23.3.0 * src snapshot updates * makeId -> htmlIdGenerator mocks * EuiCodeBlock testenv element lookup * x-pack snapshot updates * remove obsolete EuiCode and EuiCodeBlock mocks * eui to 23.3.1 * patch updates * searchbar type update * docViewer tabs use valid DOMString id * docViewer snapshot * header updates * cert_search field wrapper update

thompsongl added 11 commits May 6, 2020 11:23

eui to 23.2.0

dbebb59

Merge branch 'master' into eui/23.2.0

295d3e7

nav drawer ts updates

be7bd49

eui to 23.3.0

1bacf3c

Merge branch 'master' into eui/23.2.0

7da3abf

src snapshot updates

9e8ff77

makeId -> htmlIdGenerator mocks

1b4140d

EuiCodeBlock testenv element lookup

d42c493

x-pack snapshot updates

b6a85ed

remove obsolete EuiCode and EuiCodeBlock mocks

811abad

Merge branch 'master' into eui/23.2.0

c5b848e

thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.9.0 labels May 8, 2020

thompsongl added 4 commits May 14, 2020 15:21

Merge branch 'master' into eui/23.2.0

b83de7c

eui to 23.3.1

a073452

patch updates

7b9fbb3

Merge branch 'master' into eui/23.2.0

25bf60c

thompsongl changed the title ~~Upgrade EUI to v23.3.0~~ Upgrade EUI to v23.3.1 May 14, 2020

thompsongl added 5 commits May 15, 2020 09:47

Merge branch 'master' into eui/23.2.0

db237b5

searchbar type update

d5e7c5c

docViewer tabs use valid DOMString id

935ebfd

docViewer snapshot

2f2904a

Merge branch 'master' into eui/23.2.0

4cb40dd

thompsongl marked this pull request as ready for review May 15, 2020 21:00

thompsongl requested review from a team as code owners May 15, 2020 21:00

thompsongl requested a review from a team May 15, 2020 21:00

thompsongl requested a review from a team as a code owner May 15, 2020 21:00

pgayvallet reviewed May 15, 2020

View reviewed changes

src/core/public/chrome/ui/header/header.tsx Outdated Show resolved Hide resolved

src/core/public/chrome/ui/header/nav_link.tsx Outdated Show resolved Hide resolved

cjcenizal approved these changes May 15, 2020

View reviewed changes

header updates

39f194e

spalger approved these changes May 15, 2020

View reviewed changes

pgayvallet approved these changes May 17, 2020

View reviewed changes

flash1293 reviewed May 18, 2020

View reviewed changes

Merge branch 'master' into eui/23.2.0

11b2924

patrykkopycinski approved these changes May 18, 2020

View reviewed changes

flash1293 approved these changes May 18, 2020

View reviewed changes

shahzad31 requested changes May 18, 2020

View reviewed changes

cert_search field wrapper update

7bd47f4

thompsongl requested a review from a team as a code owner May 18, 2020 21:39

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label May 18, 2020

shahzad31 approved these changes May 19, 2020

View reviewed changes

thompsongl added 2 commits May 19, 2020 09:47

Merge branch 'master' into eui/23.2.0

e803b97

Merge branch 'master' into eui/23.2.0

7de00c6

lizozom approved these changes May 20, 2020

View reviewed changes

Merge branch 'master' into eui/23.2.0

2316573

jonathan-buttner approved these changes May 21, 2020

View reviewed changes

igoristic approved these changes May 21, 2020

View reviewed changes

poffdeluxe approved these changes May 21, 2020

View reviewed changes

thompsongl merged commit 204fd5b into elastic:master May 21, 2020

thompsongl mentioned this pull request May 21, 2020

[7.x] Upgrade EUI to v23.3.1 (#65877) #67207

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to v23.3.1 #65877

Upgrade EUI to v23.3.1 #65877

thompsongl commented May 8, 2020 •

edited

Loading

cjcenizal left a comment

spalger left a comment

pgayvallet left a comment

flash1293 May 18, 2020 •

edited

Loading

thompsongl May 18, 2020

flash1293 May 18, 2020

patrykkopycinski left a comment

flash1293 left a comment

shahzad31 left a comment

elasticmachine commented May 18, 2020

thompsongl commented May 18, 2020 •

edited

Loading

shahzad31 left a comment

lizozom left a comment

jonathan-buttner left a comment

igoristic left a comment

thompsongl commented May 21, 2020

kibanamachine commented May 21, 2020

poffdeluxe left a comment

Upgrade EUI to v23.3.1 #65877

Upgrade EUI to v23.3.1 #65877

Conversation

thompsongl commented May 8, 2020 • edited Loading

Summary

cjcenizal left a comment

Choose a reason for hiding this comment

spalger left a comment

Choose a reason for hiding this comment

pgayvallet left a comment

Choose a reason for hiding this comment

flash1293 May 18, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patrykkopycinski left a comment

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

shahzad31 left a comment

Choose a reason for hiding this comment

elasticmachine commented May 18, 2020

thompsongl commented May 18, 2020 • edited Loading

shahzad31 left a comment

Choose a reason for hiding this comment

lizozom left a comment

Choose a reason for hiding this comment

jonathan-buttner left a comment

Choose a reason for hiding this comment

igoristic left a comment

Choose a reason for hiding this comment

thompsongl commented May 21, 2020

kibanamachine commented May 21, 2020

💚 Build Succeeded

History

poffdeluxe left a comment

Choose a reason for hiding this comment

thompsongl commented May 8, 2020 •

edited

Loading

flash1293 May 18, 2020 •

edited

Loading

thompsongl commented May 18, 2020 •

edited

Loading