Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update remaining plugins with Event API #5309

Closed
suyograo opened this issue May 17, 2016 · 9 comments
Closed

Update remaining plugins with Event API #5309

suyograo opened this issue May 17, 2016 · 9 comments
Assignees
@guyboertje @untergeek
Labels
v5.0.0

Comments

@suyograo
Copy link
Contributor

suyograo commented May 17, 2016 •
edited
Loading

Issue to track updates to plugins which were not updated in #5227
@suyograo
Copy link
Contributor Author

suyograo commented Jun 1, 2016

Here's the plan:

  • Update plugins to use the new set and get API.
  • Bump version to next major
  • Add s.add_runtime_dependency "logstash-core-plugin-api", "~> 2.0" to gemspec so it depends on Plugin API v2
  • Update changelog to "Breaking: Updated plugin to use new Java Event APIs"
  • Create PR to master.
  • One the PR is reviewed, merge and publish

@suyograo
Copy link
Contributor Author

suyograo commented Jun 1, 2016

Any help here to update these plugins will be much appreciated. /cc @wiibaa @fbaligand @magnusbaeck :)

This was referenced Jun 6, 2016
Merged
Closed
Closed
This was referenced Jun 14, 2016
Closed
Closed
@3ygun 3ygun mentioned this issue Aug 5, 2016
Open
This was referenced Aug 23, 2016
Merged
Closed
This was referenced Sep 6, 2016
Closed
Closed
Closed
Closed
Merged
Merged
@wiibaa wiibaa mentioned this issue Sep 9, 2016
Merged
@ph
Copy link
Contributor

ph commented Sep 9, 2016

@suyograo Concerning the logstash-input-zenos, I believe this plugin is broken was never kept update to date. I've discovered that this plugin uses bunny BUT it also inherit Logstash::Input::RabbitMQ which uses march_hare. There is not tests in that plugin, so I am not confident that its actually working. There is an issue from March 31, logstash-plugins/logstash-input-zenoss#4 that said this plugin isn't currently working. Should we rely on the community to update it?

@wiibaa
Copy link
Contributor

wiibaa commented Sep 9, 2016

It would be good to explicitly identify which plugins should be truly deprecated and how to deprecate a plugin for 5.0, because removal from default plugins list (#5254) may not be enough to drive users

what I know is:

What would be the expectation in the logstash documentation,

  • move the deprecated plugins in a separated area ? avoiding the 404 with a deprecation notice ?
  • display a warning notice in the plugin doc ? Instead of copy-pasting a notice in each plugin, maybe providing an asciidoc include one-liner would help

Is this too much breaking changes for 5.x and its ETA ?

@boernd
Copy link

boernd commented Nov 3, 2016

What's the status of all those plugins? A lot of them do not work out of the box with 5.x (e.g. jmx input, prune filter, riemann output) atm. Any release soon?

@untergeek
Copy link
Member

The unfinished plugins are community supported. If you're volunteering to help, we would be much obliged. We get to them as fast as we are able, but that is not often as fast as people would like. That's why we are always looking for community maintainers.

@clourens
Copy link

clourens commented Dec 6, 2016 •
edited
Loading

Any news on the plugin update progress ? It's quite a big list, and I don't know if there are major changes for each plugin but this way ELK 5.0 does not seem production ready to me. I would like to help but I can barely get ELK to work, so don't think I'm qualified to update the code ;-) P.S. I'm trying to get the Extractnumbers filter to work on 5.0.2

@untergeek
Copy link
Member

but this way ELK 5.0 does not seem production ready to me

Many of these plugins, while hosted in the logstash-plugins repository, were not created by Elastic employees and are not maintained by them, except tangentially as needed. The benefit of hosting in our repository is that they can be easily found, and documentation can be on our site. So to address your "production ready" statement, there's a bit more nuance to this. These plugins are being addressed on an as-needed basis. "The squeaky wheel gets the grease," kind of thing.

I will take a look at the extractnumbers filter and see if I can update it for 5.0.

@untergeek
Copy link
Member

@clourens v3.0 of the extractnumbers filter has been published. You should be able to install it now in 5.x

@suyograo suyograo closed this as completed Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guyboertje guyboertje

@untergeek untergeek

Labels
v5.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@ph @purbon @guyboertje @wiibaa @boernd @untergeek @suyograo @clourens