mito: add support for optional types #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the latest version with the internals we depend on. Upgrading to v0.18 will take more work.
efd6
added
the
Team:Security-External Integrations
|
I have looked into v0.18 upgrade and it is reasonably straightforward. However, I think it would be prudent to wait a bit since the internals of CEL have changed significantly. |
andrewkroh
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
We can try this out against our existing Fleet integrations via 8.12 snapshots before it ships in a Filebeat release.
|
I've changed strategy to be "always on". |
andrewkroh
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings support for optional types as described here. For example (excerpted):
and
Point to consider: I've confirmed on the cel-discuss list that optional types are backwards compatible, so we could just have them always on, rather than configurable.
Please take a look.