lib,mito: add support for runtime error source location reporting #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
andrewkroh
approved these changes
Jan 22, 2024
lib/errors.go
Outdated
| type nodeIDer interface { | ||
| NodeID() int64 | ||
| } | ||
| nodeErr, ok := e.Err.(nodeIDer) |
There was a problem hiding this comment.
Would it make sense to use errors.As here to check the tree in case any wrapped errors have a NodeID?
There was a problem hiding this comment.
We can't use errors.As since it takes a concrete type. We can implement our own unwrap.
andrewkroh
approved these changes
Jan 24, 2024
| return node.NodeID(), true | ||
| } | ||
| switch x := err.(type) { | ||
| case interface{ Unwrap() error }: |
There was a problem hiding this comment.
I had no idea this was possible. TIL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look.
Best reviewed commit-wise.
tl;dr; https://github.com/elastic/mito/pull/48/files#diff-2a4e25714699ead9613fc2aadaae3b9d7d56b66f8578b27f46e03eec057aecd3
For elastic/beats#37304.