-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a -max_executions flag and config option to limit evaluations #51
Conversation
Sorry, this didn't send a review request. Is there a reason not to reflect the behaviour of the filebeat input and add a |
The idea was to be able to run a single evaluation from the command line. So needing to supply extra config in a file isn't as good, but having a flag do it just once rather than N times would be just as good. I did think it was nice to be able to specify |
I'm fine with a flag, but since we are doing this, let's also have the config field, with the flag taking precedence. |
Sounds good. Named |
Yes, to match the existing filebeat config field. |
abba66f
to
1a93ec0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message:
mito: add max_executions flag and config option to limit evaluations
When many pages are available it's handy to be able to set a limit, especially for wrapper scripts.