Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a -max_executions flag and config option to limit evaluations #51

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

chrisberkhout
Copy link
Contributor

When many pages are available it's handy to be able to set a limit, especially for wrapper scripts.

@chrisberkhout chrisberkhout self-assigned this Feb 12, 2024
@efd6
Copy link
Collaborator

efd6 commented Feb 21, 2024

Sorry, this didn't send a review request. Is there a reason not to reflect the behaviour of the filebeat input and add a max_executions field to the config? Is this purely to simulate a head?

@efd6 efd6 added the Team:Security-External Integrations Label for the Security External Integrations team label Feb 22, 2024
@chrisberkhout
Copy link
Contributor Author

The idea was to be able to run a single evaluation from the command line.

So needing to supply extra config in a file isn't as good, but having a flag do it just once rather than N times would be just as good.

I did think it was nice to be able to specify -max 0 and have it do all the checks and setup without actually running it, but that's not so important either.

@efd6
Copy link
Collaborator

efd6 commented Feb 23, 2024

I'm fine with a flag, but since we are doing this, let's also have the config field, with the flag taking precedence.

@chrisberkhout
Copy link
Contributor Author

Sounds good. Named -max_executions?

@efd6
Copy link
Collaborator

efd6 commented Feb 25, 2024

Yes, to match the existing filebeat config field.

@chrisberkhout chrisberkhout requested a review from efd6 April 26, 2024 08:55
@chrisberkhout chrisberkhout changed the title Add a -max flag to limit the number of evaluations Add a -max_executions flag and config option to limit the number of evaluations Apr 26, 2024
@chrisberkhout chrisberkhout changed the title Add a -max_executions flag and config option to limit the number of evaluations Add a -max_executions flag and config option to limit evaluations Apr 26, 2024
Copy link
Collaborator

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message:

mito: add max_executions flag and config option to limit evaluations

@chrisberkhout chrisberkhout merged commit 0f8a173 into elastic:dev Apr 26, 2024
5 checks passed
@chrisberkhout chrisberkhout deleted the max-evals branch April 26, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Security-External Integrations Label for the Security External Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants