Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix rendering of errors containing percent symbols #69

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

efd6
Copy link
Collaborator

@efd6 efd6 commented Jul 17, 2024

The call to ReportErrorAtID was rendinging the error message as a format strings, resulting in confusion when the error message included % symbols as is common in URL. This happened because the symbols were being interpretted as fmt verbs, so ensure that the string is rendered verbatim by handing is to a %s verb.

Please take a look.

@efd6 efd6 added bug Something isn't working Team:Security-Service Integrations labels Jul 17, 2024
@efd6 efd6 self-assigned this Jul 17, 2024
@efd6 efd6 requested a review from a team July 17, 2024 03:09
The call to ReportErrorAtID was rendinging the error message as a format
strings, resulting in confusion when the error message included %
symbols as is common in URL. This happened because the symbols were
being interpretted as fmt verbs, so ensure that the string is rendered
verbatim by handing is to a %s verb.
@efd6 efd6 marked this pull request as ready for review July 17, 2024 03:15
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit 8b8b0bd into dev Jul 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants