Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add diadic min and max functions #77

Merged
merged 1 commit into from
Nov 17, 2024
Merged

lib: add diadic min and max functions #77

merged 1 commit into from
Nov 17, 2024

Conversation

efd6
Copy link
Collaborator

@efd6 efd6 commented Nov 11, 2024

Please take a look.

@efd6 efd6 requested a review from a team November 11, 2024 23:27
@efd6 efd6 self-assigned this Nov 11, 2024
@efd6 efd6 marked this pull request as ready for review November 11, 2024 23:34
kcreddy
kcreddy approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

lib/collections.go Outdated
//
// <list<dyn>>.min() -> <dyn>
// min(<list<dyn>>) -> <dyn>
// max(<dyn>, <dyn>) -> <dyn>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// max(<dyn>, <dyn>) -> <dyn>
// min(<dyn>, <dyn>) -> <dyn>

@efd6 efd6 merged commit 3b51316 into dev Nov 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Team:Security-Service Integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efd6 @kcreddy