Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Extract the log level field section #3143

Merged
merged 8 commits into from
Aug 17, 2023

Conversation

mdbirnstiehl
Copy link
Contributor

This PR closes Issue 3121 and adds the Extract the log.level field to the Stream a log file documentation.

@mdbirnstiehl mdbirnstiehl self-assigned this Aug 15, 2023
@github-actions
Copy link
Contributor

A documentation preview will be available soon:

@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2023

This pull request does not have a backport label. Could you fix it @mdbirnstiehl? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 15, 2023
@mdbirnstiehl mdbirnstiehl added backport-8.9 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Aug 15, 2023
docs/en/observability/logs-stream.asciidoc Outdated Show resolved Hide resolved
}
}
----
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up request (out of scope of this PR): Show the user how to do a terms agg on the log.level field to see how many docs there are for a certain time period.

@ruflin
Copy link
Member

ruflin commented Aug 16, 2023

Overall direction LGTM, left one comment around mappings which looks off. As usual, lets get this in quickly and then iterate on it.

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

This pull request is now in conflict. Could you fix it @mdbirnstiehl? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b extract-log-level upstream/extract-log-level
git merge upstream/main
git push upstream extract-log-level

@mdbirnstiehl mdbirnstiehl marked this pull request as ready for review August 16, 2023 12:18
@mdbirnstiehl mdbirnstiehl requested a review from a team as a code owner August 16, 2023 12:18
@mdbirnstiehl mdbirnstiehl added the backport-8.10 Automated backport with mergify label Aug 16, 2023
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mdbirnstiehl mdbirnstiehl merged commit de56db9 into elastic:main Aug 17, 2023
1 check passed
@mdbirnstiehl mdbirnstiehl deleted the extract-log-level branch August 17, 2023 16:37
mergify bot pushed a commit that referenced this pull request Aug 17, 2023
mergify bot pushed a commit that referenced this pull request Aug 17, 2023
mdbirnstiehl added a commit that referenced this pull request Aug 17, 2023
(cherry picked from commit de56db9)

Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
mdbirnstiehl added a commit that referenced this pull request Aug 17, 2023
(cherry picked from commit de56db9)

Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an "Extract the log.level" section
3 participants