add Extract host IP section to logs stream docs #3155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdbirnstiehl
added
backport-8.9
|
A documentation preview will be available soon: |
mdbirnstiehl
commented
Aug 17, 2023
Comment on lines
+849
to
+860
| [source,console] | ||
| ---- | ||
| PUT /logs-example-default/_mapping | ||
| { | ||
| "properties": { | ||
| "host.ip": { | ||
| "type": "ip", | ||
| "ignore_malformed": true | ||
| } | ||
| } | ||
| } | ||
| ---- |
There was a problem hiding this comment.
Not sure if this is the recommended way of updating the mapping to ignore malformed IPs. It's what I found in the docs, but let me know if there is a preferred way.
|
|
||
| [discrete] | ||
| [[logs-stream-host-ip-query]] | ||
| === Query logs based on `host.ip` |
There was a problem hiding this comment.
CIDR notation and range queries were the two ways to query that I found most prevalent. Are there any additional ways to query we might add?
bmorelli25
reviewed
Aug 22, 2023
bmorelli25
reviewed
Aug 22, 2023
bmorelli25
approved these changes
Aug 22, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
(cherry picked from commit af924a2)
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
(cherry picked from commit af924a2)
This was referenced Aug 22, 2023
mdbirnstiehl
added a commit
that referenced
this pull request
Aug 22, 2023
mdbirnstiehl
added a commit
that referenced
this pull request
Aug 22, 2023
ruflin
reviewed
Aug 28, 2023
|
|
||
| [discrete] | ||
| [[logs-stream-ip-ignore-malformed]] | ||
| === Ignore malformed IP addresses |
There was a problem hiding this comment.
Nice way of introducing ignore_malformed 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes Issue 3122.