Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiling no kernel version check #3168

Merged
merged 11 commits into from
Aug 31, 2023
Merged

Profiling no kernel version check #3168

merged 11 commits into from
Aug 31, 2023

Conversation

iogbole
Copy link
Contributor

@iogbole iogbole commented Aug 25, 2023

No description provided.

@iogbole iogbole requested a review from a team as a code owner August 25, 2023 19:39
@github-actions
Copy link
Contributor

A documentation preview will be available soon:

@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2023

This pull request does not have a backport label. Could you fix it @iogbole? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 25, 2023
@iogbole iogbole added backport-8.9 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify 8.10-candidate labels Aug 25, 2023
christos68k
christos68k approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@christos68k christos68k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments and suggestions for clarity

docs/en/observability/profiling-advanced-configuration.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/profiling-no-kernel-version-check.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/profiling-no-kernel-version-check.asciidoc Outdated Show resolved Hide resolved
iogbole and others added 3 commits August 28, 2023 14:30
@iogbole @christos68k
Update docs/en/observability/profiling-no-kernel-version-check.asciidoc
aae8700 
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
@iogbole @christos68k
Update docs/en/observability/profiling-advanced-configuration.asciidoc
22e539d 
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
@iogbole @christos68k
Update docs/en/observability/profiling-no-kernel-version-check.asciidoc
ecd1f91 
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
mdbirnstiehl
mdbirnstiehl approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this page to the index and made a couple of grammar edits in the commit I pushed. I added a couple of comments as well, but otherwise LGTM.

docs/en/observability/profiling-advanced-configuration.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/profiling-advanced-configuration.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/profiling-no-kernel-version-check.asciidoc Outdated Show resolved Hide resolved
@iogbole @mdbirnstiehl
Update docs/en/observability/profiling-advanced-configuration.asciidoc
57ffb67 
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
@mdbirnstiehl mdbirnstiehl added the backport-8.10 Automated backport with mergify label Aug 31, 2023
@mdbirnstiehl mdbirnstiehl self-assigned this Aug 31, 2023
@mdbirnstiehl mdbirnstiehl merged commit 4ddde5d into main Aug 31, 2023
1 check passed
@mdbirnstiehl mdbirnstiehl deleted the profiling-no-kernel-version-check branch August 31, 2023 15:16
mergify bot pushed a commit that referenced this pull request Aug 31, 2023
@iogbole @mergify
Add profiling no kernel version check docs(#3168)
7f30e3c 
(cherry picked from commit 4ddde5d)
@mergify mergify bot mentioned this pull request Aug 31, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 31, 2023
@iogbole @mergify
Add profiling no kernel version check docs(#3168)
97c65b8 
(cherry picked from commit 4ddde5d)
@mergify mergify bot mentioned this pull request Aug 31, 2023
Merged
mdbirnstiehl pushed a commit that referenced this pull request Aug 31, 2023
@mergify @iogbole
Add profiling no kernel version check docs(#3168) (#3198)
840fd1d 
(cherry picked from commit 4ddde5d)

Co-authored-by: Israel Ogbole <iogbole@gmail.com>
mdbirnstiehl pushed a commit that referenced this pull request Aug 31, 2023
@mergify @iogbole
Add profiling no kernel version check docs(#3168) (#3197)
1671800 
(cherry picked from commit 4ddde5d)

Co-authored-by: Israel Ogbole <iogbole@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 left review comments

@mdbirnstiehl mdbirnstiehl mdbirnstiehl approved these changes

@christos68k christos68k christos68k approved these changes

Assignees

@mdbirnstiehl mdbirnstiehl

Labels
backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iogbole @bmorelli25 @christos68k @mdbirnstiehl