Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add conditional actions highlight #3190

Merged
merged 1 commit into from
Aug 30, 2023
Merged

[DOCS] Add conditional actions highlight #3190

merged 1 commit into from
Aug 30, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Aug 30, 2023

Relates to elastic/kibana#165137

This PR moves a "What's New" item for 8.10 into https://www.elastic.co/guide/en/observability/8.10/whats-new.html

@lcawl lcawl added the backport-8.10 Automated backport with mergify label Aug 30, 2023
@github-actions
Copy link
Contributor

A documentation preview will be available soon:

@lcawl lcawl mentioned this pull request Aug 30, 2023
Merged
@lcawl lcawl marked this pull request as ready for review August 30, 2023 20:34
@lcawl lcawl requested a review from a team as a code owner August 30, 2023 20:34
@bmorelli25 bmorelli25 changed the base branch from main to 8.10 August 30, 2023 21:11
@bmorelli25 bmorelli25 changed the base branch from 8.10 to main August 30, 2023 21:11
bmorelli25
bmorelli25 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually leave these out of main and just put them in 8.x. But changing the base branch didn't work (it never does—I don't know why GitHub even has that option). So we can merge this into main and backport.

@bmorelli25
Copy link
Member

Also, thank you!

@lcawl lcawl enabled auto-merge (squash) August 30, 2023 21:26
@lcawl lcawl merged commit 6d11e29 into elastic:main Aug 30, 2023
6 checks passed
@lcawl lcawl deleted the alerting-highlight branch August 30, 2023 21:26
mergify bot pushed a commit that referenced this pull request Aug 30, 2023
@lcawl @mergify
[DOCS] Add conditional actions highlight (#3190)
b87554b 
(cherry picked from commit 6d11e29)
@mergify mergify bot mentioned this pull request Aug 30, 2023
Merged
lcawl added a commit that referenced this pull request Aug 30, 2023
@mergify @lcawl
[DOCS] Add conditional actions highlight (#3190) (#3191)
bd9db63 
(cherry picked from commit 6d11e29)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees
No one assigned
Labels
backport-8.10 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcawl @bmorelli25