Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom metrics and histogram SLIs and partition by option #3208

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Add custom metrics and histogram SLIs and partition by option #3208

merged 3 commits into from
Sep 7, 2023

Conversation

mdbirnstiehl
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl commented Sep 5, 2023 •
edited
Loading

This PR closes Issue 3150 and Issue 3182.

Summary

In this PR, I've updated the SLI types to include Custom metrics and Histogram metrics. I have also added the Partition by option.

Preview available here

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

A documentation preview will be available soon:

@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2023

This pull request does not have a backport label. Could you fix it @mdbirnstiehl? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 5, 2023
@mdbirnstiehl mdbirnstiehl added backport-8.10 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Sep 5, 2023
@mdbirnstiehl mdbirnstiehl self-assigned this Sep 5, 2023
@mdbirnstiehl mdbirnstiehl marked this pull request as ready for review September 5, 2023 20:01
@mdbirnstiehl mdbirnstiehl requested a review from a team as a code owner September 5, 2023 20:01
kdelemme
kdelemme approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdbirnstiehl mdbirnstiehl linked an issue Sep 6, 2023 that may be closed by this pull request
[SLO] Add Custom Metric and Histogram Metric SLI types #3182
Closed
bmorelli25
bmorelli25 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmorelli25
Copy link
Member

bmorelli25 commented Sep 7, 2023 •
edited
Loading

@elasticmachine, run elasticsearch-ci/docs

We just merged the 4.x branch of the APM agent Node.js docs. Doc errors are unrelated to this PR.

@mdbirnstiehl mdbirnstiehl merged commit 2a3b2e5 into elastic:main Sep 7, 2023
1 check passed
@mdbirnstiehl mdbirnstiehl deleted the add-partition-by-to-slo branch September 7, 2023 19:17
@mergify mergify bot mentioned this pull request Sep 7, 2023
Merged
mergify bot pushed a commit that referenced this pull request Sep 7, 2023
@mdbirnstiehl @mergify
Add custom metrics and histogram SLIs and partition by option (#3208)
e7fdfdd 
(cherry picked from commit 2a3b2e5)
mdbirnstiehl added a commit that referenced this pull request Sep 7, 2023
@mergify @mdbirnstiehl
Add custom metrics and histogram SLIs and partition by option (#3208) (…
0e54d09 
…#3216)

(cherry picked from commit 2a3b2e5)

Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@kdelemme kdelemme kdelemme approved these changes

@simianhacker simianhacker Awaiting requested review from simianhacker

Assignees

@mdbirnstiehl mdbirnstiehl

Labels
backport-8.10 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SLO] Add Custom Metric and Histogram Metric SLI types [REQUEST]: SLO Group By Feature
3 participants
@mdbirnstiehl @bmorelli25 @kdelemme