Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling: add upgrade notice of known issues for 8.9 versions #3214

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

inge4pres
Copy link
Contributor

We recently discovered a problem in the setup of Universal Profiling for all customers upgrading from 7.x or earlier.

If a customer created their deployment before 8.0, so on any 7.x or earlier ESS version, they had APM server installed without a specific Fleet policy.
The Universal Profiling setup code tries to find that policy, and it was failing for these deployments.

We addressed this bug and fixed it for 8.9.3 and 8.10.0 customers.

@inge4pres inge4pres added backport backport-8.9 Automated backport with mergify v8.9.0 labels Sep 7, 2023
@inge4pres inge4pres self-assigned this Sep 7, 2023
@inge4pres inge4pres requested a review from a team as a code owner September 7, 2023 13:25
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

A documentation preview will be available soon:

[[profiling-upgrade-known-issues]]
== Known issues

If you created your {ecloud} deployment starting from a 7.x version or earlier, and you have upgraded it to 8.9.0, 8.9.1 or 8.9.2, you may encounter a problem while trying to enable Universal Profiling.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be

"and you have upgraded it to 8.9.0, 8.9.1 or 8.9.2"

->

"and you are currently upgrading it to 8.9.0, 8.9.1 or 8.9.2"

@inge4pres inge4pres added the backport-8.10 Automated backport with mergify label Sep 7, 2023
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
@inge4pres
Copy link
Contributor Author

inge4pres commented Sep 7, 2023

I moved the content of the warning to the get-started section, as it is more intuitive to have it there

Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few wording suggestions, but otherwise LGTM.

docs/en/observability/profiling-get-started.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/profiling-get-started.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/profiling-get-started.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/profiling-get-started.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
@inge4pres
Copy link
Contributor Author

A few wording suggestions, but otherwise LGTM.

Thanks 🙏🏼 all suggestion were very good to make the document more readable 👍🏼

@inge4pres inge4pres merged commit de91640 into main Sep 8, 2023
2 checks passed
@inge4pres inge4pres deleted the inge4pres-patch-1 branch September 8, 2023 13:45
mergify bot pushed a commit that referenced this pull request Sep 8, 2023
* Profiling: add upgrade notice of known issues for 8.9 versions
* move warning to get started page

Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
(cherry picked from commit de91640)
mergify bot pushed a commit that referenced this pull request Sep 8, 2023
* Profiling: add upgrade notice of known issues for 8.9 versions
* move warning to get started page

Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
(cherry picked from commit de91640)
inge4pres added a commit that referenced this pull request Sep 8, 2023
#3219)

* Profiling: add upgrade notice of known issues for 8.9 versions
* move warning to get started page

Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
(cherry picked from commit de91640)

Co-authored-by: Francesco Gualazzi <inge4pres@users.noreply.github.com>
inge4pres added a commit that referenced this pull request Sep 8, 2023
#3220)

* Profiling: add upgrade notice of known issues for 8.9 versions
* move warning to get started page

Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
(cherry picked from commit de91640)

Co-authored-by: Francesco Gualazzi <inge4pres@users.noreply.github.com>
Copy link
Contributor

@iogbole iogbole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify v8.9.0 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants