Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernise OpenTelemetry Collector example config #3518

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

axw
Copy link
Member

@axw axw commented Jan 8, 2024

@axw axw requested a review from a team as a code owner January 8, 2024 02:48
Copy link
Contributor

github-actions bot commented Jan 8, 2024

A documentation preview will be available soon:

Copy link
Contributor

mergify bot commented Jan 8, 2024

This pull request does not have a backport label. Could you fix it @axw? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 8, 2024
Noticed a couple of unrelated issues while previewing changes:
 - broken links to OTLP and Elasticsearch exporters
 - unnecessary parentheses around OTLP/gRPC and OTLP/HTTP
@colleenmcginnis colleenmcginnis added backport-8.12 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Jan 8, 2024
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmorelli25
Copy link
Member

Welcome to the repo, @axw 😄

@axw axw merged commit 1debccc into elastic:main Jan 9, 2024
7 checks passed
@axw axw deleted the otel-update-legacy-examples branch January 9, 2024 00:56
mergify bot pushed a commit that referenced this pull request Jan 9, 2024
* Use OpenTelemetry Collector `debug` exporter

The `logging` exporter is deprecated, and its
recommended replacement is the `debug` exporter.

* Use upstream-documented env var expansion syntax

See
https://opentelemetry.io/docs/collector/configuration/#environment-variables

* Update docs link

* More fixes

Noticed a couple of unrelated issues while previewing changes:
 - broken links to OTLP and Elasticsearch exporters
 - unnecessary parentheses around OTLP/gRPC and OTLP/HTTP

(cherry picked from commit 1debccc)
axw added a commit that referenced this pull request Jan 9, 2024
* Use OpenTelemetry Collector `debug` exporter

The `logging` exporter is deprecated, and its
recommended replacement is the `debug` exporter.

* Use upstream-documented env var expansion syntax

See
https://opentelemetry.io/docs/collector/configuration/#environment-variables

* Update docs link

* More fixes

Noticed a couple of unrelated issues while previewing changes:
 - broken links to OTLP and Elasticsearch exporters
 - unnecessary parentheses around OTLP/gRPC and OTLP/HTTP

(cherry picked from commit 1debccc)

Co-authored-by: Andrew Wilkins <axw@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.12 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs/otel-direct.asciidoc has outdated configuration
3 participants