Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16](backport #4300) SLO roles privileges changed #4498

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 7, 2024

Description

As described at #4229 in 8.16 the SLO permissions have changed, and also the builtin editor role is an option to grant privileges for SLOs.

This PR updates the slo-privileges.asciidoc and its associated images.
It also adds a minor change in serverless doc, as the required role to create SLOs is Editor and not Admin.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #4229

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

This is an automatic backport of pull request #4300 done by [Mergify](https://mergify.com).

* SLO roles privileges changed to match 8.16 release

* editor builtin role information added

* wording and order of privileges options changed

* minor wording changes

* serverless required role updated

* rephrasing permissions

Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>

* removing future tense

Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>

* Update docs/en/observability/slo-privileges.asciidoc

change see by check

Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>

---------

Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
(cherry picked from commit bb910be)

# Conflicts:
#	docs/en/serverless/slos/create-an-slo.mdx
@mergify mergify bot requested a review from a team as a code owner November 7, 2024 09:04
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Nov 7, 2024
Copy link
Contributor Author

mergify bot commented Nov 7, 2024

Cherry-pick of bb910be has failed:

On branch mergify/bp/8.16/pr-4300
Your branch is up to date with 'origin/8.16'.

You are currently cherry-picking commit bb910bea.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	deleted:    docs/en/observability/images/slo-es-priv-all.png
	new file:   docs/en/observability/images/slo-es-priv-editor.png
	deleted:    docs/en/observability/images/slo-es-priv-read.png
	new file:   docs/en/observability/images/slo-es-priv-viewer.png
	modified:   docs/en/observability/slo-privileges.asciidoc

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   docs/en/serverless/slos/create-an-slo.mdx

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot assigned eedugon Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@bmorelli25 bmorelli25 removed the conflicts There is a conflict in the backported pull request label Nov 7, 2024
@bmorelli25 bmorelli25 merged commit a808a00 into 8.16 Nov 7, 2024
3 checks passed
@bmorelli25 bmorelli25 deleted the mergify/bp/8.16/pr-4300 branch November 7, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants