Remove hard-coded tenant role ARN.

[anelson]

This was used for development. It's not needed in production, since the CFN generated by the Elastio tenant API will have the appropriate tenant role ARN hard-coded as the default value for the parameter.

Summary by CodeRabbit

• New Features

  • Enhanced management of service-linked roles for improved deployment processes.
  • Introduced new cloud connector deployment logic for better integration with existing services.

• Bug Fixes

  • Ensured proper dependencies between service-linked roles and CloudFormation stacks to prevent deployment issues.

• Refactor

  • Reorganized local variables for clarity and efficiency in configuration management.

[coderabbitai]

Walkthrough

The changes in the Terraform configuration file elastio-terraform-deployment/module/main.tf include the addition and restructuring of local variables, notably removing tenantRoleArn from global_acc_cfn_params. A new variable for service-linked roles has been introduced, and dependencies have been established to ensure these roles are created prior to provisioning CloudFormation stacks. Additionally, a new local variable for cloud connector deployment requests has been added, enhancing the deployment process with a curl command for executing requests.

Changes

File Path	Change Summary
elastio-terraform-deployment/module/main.tf	- Removed tenantRoleArn from global_acc_cfn_params
	- Added service_linked_roles_services local variable
	- Added elastio_cloud_connector_deploy_requests local variable
	- Updated aws_cloudformation_stack resources to depend on terraform_data.service_linked_roles
	- Modified elastio_nat_provision_stack for conditional creation based on var.elastio_nat_provision_stack
	- Updated terraform_data.elastio_cloud_connector resource to utilize the new local variable with a curl command

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Terraform
    participant AWS

    User->>Terraform: Initiate deployment
    Terraform->>AWS: Create service-linked roles
    AWS-->>Terraform: Roles created
    Terraform->>AWS: Provision CloudFormation stacks
    AWS-->>Terraform: Stacks provisioned
    Terraform->>AWS: Deploy cloud connectors with curl
    AWS-->>Terraform: Connectors deployed

Loading

🐰 "In the fields where the bunnies play,
New roles and stacks come out to stay.
With curl we hop, to deploy with glee,
A world of clouds, just wait and see!
So let us dance, with joy and cheer,
For Terraform's magic is finally here!" 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 4bf758f and 7bb1fbe.

📒 Files selected for processing (1)

• elastio-terraform-deployment/module/main.tf (0 hunks)

💤 Files with no reviewable changes (1)

• elastio-terraform-deployment/module/main.tf

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Veetaha]

😳