Reload doesn't work on Ubuntu & Fedora #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anelson
approved these changes
Sep 20, 2023
vsazhenyuk-softheme
approved these changes
Sep 20, 2023
skypodolsky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces two fixes for Fedora and Ubuntu distributives to make the reload functionality work.
In general, this resolves the issues with false umounts. For Fedora, it was seen that the umount of the '.' directory took place during operation. There were no results in finding the exact instance that does it and why, but it doesn't look okay for regular operation. Hence, the code was corrected to accept only absolute paths instead of absolute + relative (as in this situation).
For Ubuntu the problem was different. Additional mount points were created for the root volume, which caused false umount handling in the driver. To fix that, we now check the vfsmount pointers to ensure we are dealing with the initial root volume.
Closes #292