Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: honour KeepHeader on https connections #460

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mvanholsteijn
Copy link

@mvanholsteijn mvanholsteijn commented Dec 28, 2021

My https proxy inserts a new proxy-authorization header in the OnRequest() method, which is removed in https.go

  • I added the if !proxy.KeepHeader condition around the removeProxyHeaders call in https.go just like it was added in proxy.go
  • I changed the name from removeProxyHeaders to RemoveProxyHeaders to allow the headers to be removed from an OnRequest() method.

closes #453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The keepHeaders option does not work on https connections
1 participant