Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DELETE database_id shall clean up replication slot #1924

Closed
balegas opened this issue Nov 5, 2024 · 0 comments · Fixed by #1965
Closed

DELETE database_id shall clean up replication slot #1924

balegas opened this issue Nov 5, 2024 · 0 comments · Fixed by #1965
Assignees

Comments

@balegas
Copy link
Contributor

balegas commented Nov 5, 2024

When we DELETE a database we tear down the processes related with it, but still leave the replication slot. Given this is an action to delete the database, it means the user is no longer interested in shapes sources by it and should delete any associated resources: storage and replication slot.

Leaving replication slots hanging is a problem for users and the WAL file will keep growing unexpectedly. We should also take care of teardown for single-tenant electric #1923.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants