Skip to content

Commit

Permalink
feat: Added support for overriding ‘preAutoEntitlements’ for electron…
Browse files Browse the repository at this point in the history
…/osx-sign (#7642)
  • Loading branch information
taozhou-glean authored Jul 4, 2023
1 parent 5fec686 commit 2717282
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/four-starfishes-invite.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-lib": minor
---

feat: Added support for overriding ‘preAutoEntitlements’ for electron/osx-sign
10 changes: 10 additions & 0 deletions packages/app-builder-lib/scheme.json
Original file line number Diff line number Diff line change
Expand Up @@ -2679,6 +2679,11 @@
],
"description": "Options to use for @electron/notarize (ref: https://github.com/electron/notarize).\nSupports both `legacy` and `notarytool` notarization tools. Use `false` to explicitly disable\n\nNote: You MUST specify `APPLE_ID` and `APPLE_APP_SPECIFIC_PASSWORD` via environment variables to activate notarization step"
},
"preAutoEntitlements": {
"default": true,
"description": "Whether to enable entitlements automation from @electron/osx-sign.",
"type": "boolean"
},
"protocols": {
"anyOf": [
{
Expand Down Expand Up @@ -3304,6 +3309,11 @@
],
"description": "Options to use for @electron/notarize (ref: https://github.com/electron/notarize).\nSupports both `legacy` and `notarytool` notarization tools. Use `false` to explicitly disable\n\nNote: You MUST specify `APPLE_ID` and `APPLE_APP_SPECIFIC_PASSWORD` via environment variables to activate notarization step"
},
"preAutoEntitlements": {
"default": true,
"description": "Whether to enable entitlements automation from @electron/osx-sign.",
"type": "boolean"
},
"protocols": {
"anyOf": [
{
Expand Down
1 change: 1 addition & 0 deletions packages/app-builder-lib/src/macPackager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
binaries,
// https://github.com/electron-userland/electron-builder/issues/1480
strictVerify: options.strictVerify,
preAutoEntitlements: options.preAutoEntitlements,
optionsForFile: await this.getOptionsForFile(appPath, isMas, customSignOptions),
provisioningProfile: customSignOptions.provisioningProfile || undefined,
}
Expand Down
6 changes: 6 additions & 0 deletions packages/app-builder-lib/src/options/macOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,12 @@ export interface MacConfiguration extends PlatformSpecificBuildOptions {
*/
readonly strictVerify?: boolean

/**
* Whether to enable entitlements automation from @electron/osx-sign.
* @default true
*/
readonly preAutoEntitlements?: boolean

/**
* Regex or an array of regex's that signal skipping signing a file.
*/
Expand Down

0 comments on commit 2717282

Please sign in to comment.