-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: windows signature verification special chars (#8409)
* fix: windows signature verification special chars by applying #8051 and noted in #8162 win signature verification of signatures created using certificates including special chars like german umlauts got broken in electron-updater >= 1.6.9. The issue at hand is that the windows set command does not terminate when reading semicolon `;` and setting %PATH% is a good example for this c.f. https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-xp/bb490998(v=technet.10) so instead commands should be concatenated using `&` Closes #8162
- Loading branch information
Showing
2 changed files
with
8 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"electron-updater": patch | ||
--- | ||
|
||
fix: windows signature verification special chars |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters