-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement autoupdates for pacman #8394
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 27cd56e The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@mmaietta @beyondkmp Is this normal? |
Nice work @xyloflake! I'm going to work on getting a new release set up on my electron-builder-test repo so that we can have the |
Yay! Thank you! As I can see, the tests fails at the Pacman test. I can't seem to figure out what went wrong. Edit: Figured it out. It fetches the executables from your electron-builder-test repo and it can't verify on pacman because the executable for pacman was never built. I've made a PR to make your work easier. You just need to run a github action for the release now :) |
@mmaietta should this PR result in major or minor version bump? I think minor as according to semver the minor in MAJOR.MINOR.PATCH must be incremented when a new feature is implemented? |
@mmaietta Hi, I wanted to give you an update on the asynchronous install PR—it's about 70% complete, and I'm in the phase of making and testing changes. I've realized that this PR will require another modification once the asynchronous PR is ready because the The challenge is that I'm working on both PRs simultaneously. To avoid conflicts, one of these PRs will need to be merged after the other. Should I commit the necessary changes for |
This reverts commit 8fc4c1c.
It should be a Regarding the rollout of this autoupdate feature. I think you'll need to do 2 releases, one with the initial pacman release with electron-updater pacman support integrated, then another release to actually trigger the pacman autoupdate feature. Re: the |
Got it! Thanks.
That is absolutely correct, you need to make a release for 1.0.4 with initial Pacman support and then 1.0.5 for testing the update.
Seems like the most appropriate thing to do! I'm completely okay with that :) |
@mmaietta can we merge this instead? And change it for pacman in the other PR. |
@xyloflake how can I test this locally on a linux VM? Preferably via Parallels Desktop. I trust your testing, but I feel I should still give it a look once-over |
You need some arch linux or derivative linux distro to support pacman. Otherwise there's no other way. If you want, I can give you remote access to my arch machine but we'd need to be in a call then because testing it is complicated. However I 100% do guarantee that this is not flawed and has been appropriately tested. If you do want to use a linux VM, you need the arch VM |
@mmaietta Alright I'll write up the instructions for once you get an arch VM up and running. Please use pnpm as patches are easier to configure. And most importantly, find out a way to display your version in the electron app before doing all of this as to confirm that update was indeed successful.
|
Sorry I do not know how Parallel Desktop works and I haven't personally used it. But you'd need to setup an arch vm somehow to test this. And let me warn you before you try: installing arch is one of the most complicated things to do. One wrong command like using archinstall instead of the documented commands might break your system and drive. It's overwhelmingly frustrating and time consuming. It took me about 1.5 hours to get arch up and running. If you have the time, patience and can afford breaking your system, I'll be happy to help. Otherwise this can go through an alpha version and once it's considered stable, we can make it beta. |
I can upload a video proof of updation taking place if you want as well. My colleague @gamersi has also tested it on 2 different devices. |
On a VM you can just use archinstall, works 9/10 times as there is just one disk. Where archinstall is really bad is with custom disk configurations which you don't have on a VM. |
Happy to test w/Arch on real hardware if needed (been daily-driving arch since 2012). |
@Bug-Reaper please follow the steps then and report if it autoupdates :) |
Hey @xyloflake just wanted to let you know I tentatively plan to test this either tmmo or Thurs! CC: @mmaietta - I can screen-record this and/or assist w/your VM setup and potentially some type of automated VM/Docker setup for tests as needed just lmk 👍 |
Super cool! Looking forward to it :) |
@mmaietta have you tested it yet? |
@xyloflake Haven't had time to set up my dev environment. Will be back from vacation on 8/3 |
Hi @mmaietta, back yet? |
Will try to get this soon. Full transparency, currently working through a family issue with someone who is EOL @Bug-Reaper were you able to test this on your end? |
Update:
Developer's note: Instead of using yalc, I just use resync to force copy all additional assets over to my test project (assuming the projects in the same root dir (~/Development in my case). I've saved it as an alias in my zsh profile for easy access
|
@mmaietta that's quite sad to hear. I hope you through it soon and best wishes from my end. All I can say that all life on earth has to come to an unfortunate end and it's pretty sad. I hope you find the strength and courage to get over it and remember that person with all the good memories. I am so so sorry. |
Sorry, I don't really know about parallels vm so I'll request @gamersi to help you if possible.
I've never even heard of resync. What we do at muffon for consistency and development testing is that we do a simple pnpm patch and then copy the electron builder source build with the out folder contents and then finally we do pnpm patch-commit. Of course it is inefficient but it's the most stable among all because yalc sometimes skips changes and it's pretty hard to say if the version was changed or not without opening node modules. |
That's what |
Why rsync and not cp? Isn’t rsync made for copying over network? concering the VM - you are not gonna have much luck with virtualization - there is arch Linux arm but it only has 1 maintainer who is so overworked that he sometimes doesn’t have time to update to the latest kernel. You could use that but support is bad and versions are sometimes weeks to months behind. So I would recommend to emulate x86-64 |
Absolutely correct. Trying on a M series macbook will create problems nevertheless because of the ARM architecture. |
… instead of major
…t's required this way, but the changes in app-builder-lib does not impact currently existing code
So I can't figure out why |
@xyloflake @Bug-Reaper @gamersi In order to move forward, I'd like evidence that the update process completes successfully (since I can't set up an Arch Linux VM on arm64 macs from what I am understanding) Please post back logs from electron-updater as well so that we can debug anything further (if necessary). Logging can be added via:
|
You can test it: It is also based on QEMU which is very well developed and has been around for quite some time |
We can do that. Cool idea. Saves a lot of manual labour actually for ya. @gamersi since I'm busy and will reach home around 12:30pm ET, can you make a build of muffon and send the logs here? I'll be late as I have school today 🙂 |
@mmaietta update? |
Introducing autoupdate support for pacman!
I have updated docs & tests plus ran all tests.
I have also pushed an update to the pnpm lockfile which was auto-generated during
pnpm update