Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update typescript 5.x lockfile #8516

Merged
merged 2 commits into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/plenty-sheep-argue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"app-builder-lib": patch
"builder-util": patch
"builder-util-runtime": patch
"dmg-builder": patch
"electron-updater": patch
---

fix(chore): upgrading typescript and fixing compiler errors
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@
"@changesets/cli": "2.25.0",
"@stylistic/eslint-plugin": "^2.8.0",
"@types/node": "^22.5.5",
"@typescript-eslint/eslint-plugin": "^8.0.0",
"@typescript-eslint/parser": "^8.0.0",
"@typescript-eslint/eslint-plugin": "^8.6.0",
"@typescript-eslint/parser": "^8.6.0",
"conventional-changelog-cli": "5.0.0",
"eslint": "^8.56.0",
"eslint-config-prettier": "^9.1.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,8 @@ export class WindowsSignToolManager {
(e: any) => {
if (
e.message.includes("The file is being used by another process") ||
e.message.includes("The specified timestamp server either could not be reached" || e.message.includes("No certificates were found that met all the given criteria."))
e.message.includes("The specified timestamp server either could not be reached") ||
e.message.includes("No certificates were found that met all the given criteria.")
) {
log.warn(`Attempt to code sign failed, another attempt will be made in 15 seconds: ${e.message}`)
return true
Expand Down
2 changes: 1 addition & 1 deletion packages/electron-updater/src/DownloadedUpdateHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export class DownloadedUpdateHelper {
return null
}

const isCachedInfoFileNameValid = cachedInfo?.fileName !== null ?? false
const isCachedInfoFileNameValid = cachedInfo?.fileName !== null
if (!isCachedInfoFileNameValid) {
logger.warn(`Cached update info is corrupted: no fileName, directory for cached update will be cleaned`)
await this.cleanCacheDirForPendingUpdate()
Expand Down
105 changes: 56 additions & 49 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading