Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing fails in Yarn PnP environments #283

Open
connorworley opened this issue May 10, 2023 · 4 comments
Open

Signing fails in Yarn PnP environments #283

connorworley opened this issue May 10, 2023 · 4 comments

Comments

@connorworley
Copy link

connorworley commented May 10, 2023

osx-sign will attempt to pass a PnP zip path to codesign, which it can't read, resulting in an error:

WARNING: Code sign failed; please retry manually. Error: Command failed: codesign <snip> --entitlements /Users/connor.worley/Code/github.com/connorworley/karafriends/.yarn/cache/@electron-osx-sign-npm-1.0.4-aaf9a8f648-0d7382922e.zip/node_modules/@electron/osx-sign/entitlements/default.darwin.plist <snip>

It seems like copying the default entitlements files to a tmp directory and returning that path indefaultOptionsForFile would be a sufficient fix.

@sibljon
Copy link

sibljon commented Aug 28, 2023

I'm running into this very issue, and I can't get past it. Any ideas?

@connorworley
Copy link
Author

I had to switch back to nodeLinker: node-modules :\

@sibljon
Copy link

sibljon commented Aug 28, 2023

Ahh, too bad. Thanks for the follow up!

@roblillack
Copy link

@connorworley, @sibljon: You can work around this issue by making sure the package is unzipped during the installation phase:

yarn unplug @electron/osx-sign -R

You might then want to repeat the step for dmg-builder, too, which has a comparable issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants