Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-tenant queries in streaming search #1

Closed
wants to merge 7 commits into from

Conversation

electron0zero
Copy link
Owner

What this PR does:

Add multi-tenant query support in streaming Search endpoints does not support multi-tenant queries.

follow up on grafana#3087

Which issue(s) this PR fixes:
Fixes grafana#1858

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

* Make autocomplete filtering default to true

* chlog
joe-elliott and others added 6 commits December 15, 2023 07:42
* page caching first pass

Signed-off-by: Joe Elliott <number101010@gmail.com>

* set default vals

Signed-off-by: Joe Elliott <number101010@gmail.com>

* actually return cache

Signed-off-by: Joe Elliott <number101010@gmail.com>

* disallow none cache

Signed-off-by: Joe Elliott <number101010@gmail.com>

* restore buffered reader

Signed-off-by: Joe Elliott <number101010@gmail.com>

* fix read buffer size

Signed-off-by: Joe Elliott <number101010@gmail.com>

* remove load

Signed-off-by: Joe Elliott <number101010@gmail.com>

* changelog

Signed-off-by: Joe Elliott <number101010@gmail.com>

* fix stopping behavior

Signed-off-by: Joe Elliott <number101010@gmail.com>

* copy before storing parquet pages

Signed-off-by: Joe Elliott <number101010@gmail.com>

* combined cached reader and optimized reader

Signed-off-by: Joe Elliott <number101010@gmail.com>

* lint/asserts

Signed-off-by: Joe Elliott <number101010@gmail.com>

* simplify needsCopy

Signed-off-by: Joe Elliott <number101010@gmail.com>

* add parquet-pages to docs

Signed-off-by: Joe Elliott <number101010@gmail.com>

* add stoewer file?

Signed-off-by: Joe Elliott <number101010@gmail.com>

* perhaps this incantation will work, mused the lonely wizard

Signed-off-by: Joe Elliott <number101010@gmail.com>

---------

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
* Add combiners to frontend

---------

Co-authored-by: Mario <mariorvinas@gmail.com>

* Add MultiTenantQueriesEnabled config in frontend

* Add MultiTenantMiddleware and tests

---------

Co-authored-by: Mario <mariorvinas@gmail.com>

* Expose dedicated handler in queryfrontend for each http endpoint

* Add multi-tenant middleware in multi-tenant routes

* ignore e2e test folder

* fix up

* search methods on client

* Add e2e test TestMultiTenantSearch

* Add NewSearchTagsV2 combiner

* test are passing...

* test cleanup

* docs & todos

* make lint happy

* use distinct value collector

* Add docs

* remove callback from combiner AddRequest

* leave a todo to merge CombineSearchResults

* return multi-tenant query unsupported for metrics endpoint

* add a note on testing search streaming locally

* update docs for lowercase headers

* streaming search endpoints unsupported error

* multi-tenant works in streaming search? who knows?

* remove todo

* update gitignore & local docker-compose file

* test unsupported endpoints in e2e search

* Update CHANGELOG.md

* Add tests for unsupprted endpoints

* more cleanup

* fix lint

* fix golangci

* assert response for tags endpoints

* docs feedback

Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>

* reword and fix docs

---------

Co-authored-by: Mario <mariorvinas@gmail.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants