Add screenshot tests, coverage and publishing GH flows #5
Conversation
- Replace Paparazzi with Roborazzi. - Update icons from Compound. - Add Material You tests.
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
jmartinesp
changed the title
github-actions
bot
removed
the
Record-Screenshots
Also do some import cleanup
compound/build.gradle.kts
Outdated
| testImplementation(libs.test.roborazzi) | ||
| testImplementation(libs.test.roborazzi.compose) | ||
| testImplementation(libs.test.roborazzi.junit) | ||
| testImplementation(libs.test.roborazzi.junit) |
There was a problem hiding this comment.
Looks like there is a duplicated line here.
compound/build.gradle.kts
Outdated
| minValue = 80 | ||
| // Setting a max value, so that if coverage is bigger, it means that we have to change minValue. | ||
| // For instance if we have minValue = 20 and maxValue = 30, and current code coverage is now 31.32%, update | ||
| // minValue to 25 and maxValue to 35. |
There was a problem hiding this comment.
Maybe remove this comment, since there is no maxValue here.
| @@ -54,6 +60,7 @@ fun ColorPreview( | |||
| Box( | |||
| modifier = Modifier | |||
| .padding(1.dp) | |||
| .background(Color.White) | |||
There was a problem hiding this comment.
Does it have an effect? There is line 64 which set a background as well.
There was a problem hiding this comment.
Yes: without this, the colors that have an alpha value are overlayed directly above this component's parent background, which is a gradient, and it's difficult to really understand what the color looks like unless you take a look at both extremes of each item (the pure white/black colors).
Although it might be that what we wanted when using the gradient, I'm not sure. I found it quite confusing myself.
There was a problem hiding this comment.
The gradient idea was to add a border with "several" colors. So it's fine to set a White bg, I did not think about colors with alpha. Thanks!
| @Composable | ||
| internal fun AvatarColorsDarkPreview() { | ||
| val chunks = avatarColorsDark.chunked(4) | ||
| ElementTheme { |
There was a problem hiding this comment.
I think you want to force a dark theme here.
| ElementTheme { | |
| ElementTheme(darkTheme = true) { |
but the generated screenshots are correct since avatarColorsDark is used here. So just ignore me!
| ui-tooling-preview-android = "1.5.4" | ||
| ui-tooling-preview-android = "1.6.1" | ||
| kover = "0.7.5" | ||
| roborazzi = "1.9.0" |
There was a problem hiding this comment.
We will probably need to setup Renovate on this repo to handle the upgrades
There was a problem hiding this comment.
Let me know if it's something I can do.
Changes:
ic_compound_prefix instead ofic_to avoid collisions with app or library resources.CompoundIconsvector icon helpers are now functions (needed to get better coverage with Kover).