Update avatar colors to the new semantic ones in Compound #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
the
Record-Screenshots
jmartinesp
force-pushed
the
misc/jme/update-avatar-colors
branch
from
ff71613
to
30836c3
Compare
github-actions
bot
removed
the
Record-Screenshots
bmarty
reviewed
Sep 23, 2024
There was a problem hiding this comment.
I am surprised that the colors are identical for light or dark. Maybe an issue in the code (see my other comment)
| ElementTheme { | ||
| internal fun AvatarColorsPreviewDark() { | ||
| val chunks = avatarColors().chunked(4) | ||
| ElementTheme(darkTheme = true) { |
There was a problem hiding this comment.
The avatarColors() should be invoked inside the ElementTheme block maybe?
There was a problem hiding this comment.
It should be fixed in 91270a4. Nice catch!
github-actions
bot
removed
the
Record-Screenshots
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also needed to change the signature to a single composable function.