Make tooltips more touchscreen-friendly #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current behavior on touchscreens is that tooltips will open as soon as you touch the trigger and remain open indefinitely due to focus and simulated hover. This feels unexpected, particularly on mobile. The solution implemented here is to ignore non-visible focus and simulated hover events, and instead allow tooltips to be opened by long-pressing on the trigger. This matches the behavior of native tooltips on Android (though I don't know whether iOS has this same interaction pattern).
Deploying compound-web with
|
| Latest commit: |
9b0ec47
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e7c5febb.compound-web.pages.dev |
| Branch Preview URL: | https://mobile-tooltips.compound-web.pages.dev |
robintown
added a commit
to robintown/element-call
that referenced
this pull request
Nov 8, 2024
I put up a temporary build of element-hq/compound-web#272 for us to use.
t3chguy
approved these changes
Nov 11, 2024
robintown
added a commit
to robintown/element-call
that referenced
this pull request
Nov 11, 2024
element-hq/compound-web#272 got merged and released.
hughns
pushed a commit
to element-hq/element-call
that referenced
this pull request
Nov 11, 2024
element-hq/compound-web#272 got merged and released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior on touchscreens is that tooltips will open as soon as you touch the trigger and remain open indefinitely due to focus and simulated hover. This feels unexpected, particularly on mobile.
The solution implemented here is to ignore non-visible focus and simulated hover events, and instead allow tooltips to be opened by long-pressing on the trigger. This matches the behavior of native tooltips on Android (though I don't know whether iOS has this same interaction pattern).