Keep screenshares when switching focus #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the use of the useLivekitRoom hook: we had reached the point where the only thing it was actually doing was disconnecting, so we now do that in the onClick handler for the leave button (I don't think we need to disconnect on unmount?). It was otherwise just getting in the way and causing tracks to be enabled/disabled when we didn't want them to be. This also removes the need for the blockAudio code. Fixes #1413
dbkr
added
the
T-Defect
toger5
reviewed
Nov 10, 2023
src/livekit/useLiveKit.ts
Outdated
There was a problem hiding this comment.
The useLiveKit file with the hook still seems to be here? Did I misunderstand the PR description? It sounded like this would be removed
There was a problem hiding this comment.
useLivekitRoom is the hook provided by Livekit components which is being removed. useLivekit is our own hook.
robintown
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the use of the useLivekitRoom hook: we had reached the point where the only thing it was actually doing was disconnecting, so we now do that in the onClick handler for the leave button (I don't think we need to disconnect on unmount?). It was otherwise just getting in the way and causing tracks to be enabled/disabled when we didn't want them to be. This also removes the need for the blockAudio code.
Fixes #1413
Based on: #1891