Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark E2EEenabled flag as deprecated #1895

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Nov 14, 2023

@dbkr If I understand your comment on the other PR right, this is the correct description for this flag.

Signed-off-by: Timo K <toger5@hotmail.de>
@toger5 toger5 requested a review from a team as a code owner November 14, 2023 09:08
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (daf6e67) 30.14% compared to head (514bf03) 30.14%.

Additional details and impacted files
@@           Coverage Diff            @@
##           livekit    #1895   +/-   ##
========================================
  Coverage    30.14%   30.14%           
========================================
  Files           47       47           
  Lines         1874     1874           
  Branches       327      327           
========================================
  Hits           565      565           
  Misses        1264     1264           
  Partials        45       45           
Flag Coverage Δ
unittests 30.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this is accurate.

@toger5 toger5 merged commit 85250e6 into livekit Nov 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants