Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard shortcuts for raised hand / reactions #2784

Merged
merged 16 commits into from
Nov 19, 2024
Merged

Add keyboard shortcuts for raised hand / reactions #2784

merged 16 commits into from
Nov 19, 2024
+173 −127

Conversation

Half-Shot
Copy link
Member

This is mostly moving more of the event sending code to useReactions, and then hooking up to the existing keyboard shortcuts code

@Half-Shot Half-Shot requested a review from a team as a code owner November 14, 2024 17:23
robintown
robintown reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine but I have one design suggestion: could we use the caption field of tooltips here for the shortcuts? (cf Element Web)

Screenshot from 2024-11-19 10-46-07

@Half-Shot Half-Shot merged commit b3ceb53 into livekit Nov 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robintown robintown robintown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @robintown