-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React to theme changes in widget mode #2910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the lint errors, which I think will then show the typings errors due to dependency on the unmerged PR in matrix-widget-api.
Please can you add the necessary version bump to package.json and yarn.lock?
Some comments inline.
Lints fixed, I plan to bump the matrix-widget-api version once the linked PR is reviewed and released. (That's what I should've used the 'blocked' label for) |
The rust widget driver does not send the theme change action iirc. |
I've merged matrix-org/matrix-widget-api#119 so I think this PR is now unblocked. |
Marking as draft until updated with the upstream dep to fix the typechecking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Part of the fix for element-hq/element-web#27671
Depends on:
Expand support for MSC2873 (changing theme/language) matrix-org/matrix-widget-api#117
Export theme and language action types matrix-org/matrix-widget-api#119
created issue for the rust-sdk widget driver