Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React to theme changes in widget mode #2910

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

robintown
Copy link
Member

@robintown robintown commented Dec 18, 2024

Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the lint errors, which I think will then show the typings errors due to dependency on the unmerged PR in matrix-widget-api.

Please can you add the necessary version bump to package.json and yarn.lock?

Some comments inline.

src/useTheme.ts Show resolved Hide resolved
src/useTheme.ts Show resolved Hide resolved
@robintown
Copy link
Member Author

Lints fixed, I plan to bump the matrix-widget-api version once the linked PR is reviewed and released. (That's what I should've used the 'blocked' label for)

@robintown robintown requested a review from hughns January 2, 2025 18:36
@toger5
Copy link
Contributor

toger5 commented Jan 3, 2025

The rust widget driver does not send the theme change action iirc.
I will check if it at least the url property is set by the rust sdk. (edit: url properties are supported by the rust sdk)
Can we create issues for the rust-sdk repo to add those features as port of this pr?

@hughns
Copy link
Member

hughns commented Jan 8, 2025

I've merged matrix-org/matrix-widget-api#119 so I think this PR is now unblocked.

@hughns hughns removed the X-Blocked label Jan 8, 2025
@hughns
Copy link
Member

hughns commented Jan 8, 2025

Marking as draft until updated with the upstream dep to fix the typechecking.

@hughns hughns marked this pull request as draft January 8, 2025 16:05
Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@robintown robintown merged commit 8bfdd1f into element-hq:livekit Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants