Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second-click when joining a room to stop accidental joins #2001

Open
daniellekirkwood opened this issue Aug 22, 2023 · 2 comments
Open

Second-click when joining a room to stop accidental joins #2001

daniellekirkwood opened this issue Aug 22, 2023 · 2 comments
Labels
A-Invite A-Room T-Enhancement X-Needs-Product More input needed from the Product team

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Aug 22, 2023

Your use case

"the issue I've had was when searching the public directory for specific keywords and pressing enter to search without realising 'join' was highlighted, so just hitting enter on my keyboard automatically joined me to the room."

What would you like to do?

When joining a room present the user with a second click so that users can't accidentally join rooms (especially if they're 'bad')

Why would you like to do it?

Raised by a member of the Element team in an internal room

How would you like to achieve it?

Have you considered any alternatives?

No response

Additional context

No response

@daniellekirkwood daniellekirkwood added T-Enhancement X-Needs-Product More input needed from the Product team A-Invite A-Room labels Aug 22, 2023
@daniellekirkwood
Copy link
Contributor Author

Screenshot 2023-08-22 at 10 37 24

On this screen the key-press ENTER joins you to the room

@deniseal
Copy link
Member

Essentially, it would be helpful to have a confirmation dialogue before joining public rooms. I imagine this could be a bit annoying for most users, so maybe an optional feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Invite A-Room T-Enhancement X-Needs-Product More input needed from the Product team
Projects
None yet
Development

No branches or pull requests

2 participants